Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8679004: Remove default plug-in on Mac, Gtk and Aura. (Closed)

Created:
9 years, 1 month ago by Bernhard Bauer
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, ananta
Visibility:
Public.

Description

Remove default plug-in on Mac, Gtk and Aura. Aura doesn't do plug-ins, and Mac and Gtk already use in-renderer placeholders. BUG=62079 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111519

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1134 lines) Patch
M chrome/chrome_common.gypi View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/default_plugin/default_plugin.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/default_plugin/plugin_impl_aura.h View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/default_plugin/plugin_impl_aura.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/default_plugin/plugin_impl_gtk.h View 1 chunk +0 lines, -281 lines 0 comments Download
D chrome/default_plugin/plugin_impl_gtk.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/default_plugin/plugin_impl_mac.h View 1 chunk +0 lines, -295 lines 0 comments Download
D chrome/default_plugin/plugin_impl_mac.mm View 1 chunk +0 lines, -204 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review.
9 years, 1 month ago (2011-11-23 21:51:35 UTC) #1
jam
lgtm
9 years, 1 month ago (2011-11-23 22:02:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/8679004/3001
9 years, 1 month ago (2011-11-24 09:39:19 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 10:51:46 UTC) #4
Change committed as 111519

Powered by Google App Engine
This is Rietveld 408576698