Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 8678031: Optimize type checks of list and map literals. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 1825)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -757,7 +757,7 @@
return Api::Error(msg);
}
const Type& type = Type::Handle(Type::NewNonParameterizedType(cls));
- *value = instance.Is(type);
+ *value = instance.IsInstanceOf(type, TypeArguments::Handle());
return Api::Success();
}
@@ -1129,7 +1129,9 @@
Instance& instance = Instance::Handle();
instance ^= obj.raw();
const Type& type = Type::Handle(isolate->object_store()->list_interface());
- return instance.Is(type) ? instance.raw() : Instance::null();
+ if (instance.IsInstanceOf(type, TypeArguments::Handle())) {
+ return instance.raw();
+ }
}
return Instance::null();
}
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698