Ensure swap is performed before informing compositor.

Ensure swap is performed before informing compositor.

This can prevent a possible race condition. This can cause an issue for NaCl where the command buffer swap will occur even if the callback returns an error, but that just matches the normal pepper proxy's behavior, and shouldn't really cause any issues in practice.


BUG=99643
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111465

[piman, 2011-11-23 22:43:22]

lgtm

[nfullagar, 2011-11-23 22:51:18]

http://codereview.chromium.org/8678028/diff/1/ppapi/native_client/src/shared/...
File ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc
(right):

http://codereview.chromium.org/8678028/diff/1/ppapi/native_client/src/shared/...
ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc:245:
impl()->SwapBuffers();
what's going to happen if the NaClSrpcError retval returns an error below? 
There will be a pending impl()->SwapBuffer() but the RPC failed?

[nfullagar, 2011-11-23 22:53:03]

Sorry, just saw that this is already mentioned in the CL description.  lgtm
if it isn't a problem.

On Wed, Nov 23, 2011 at 2:51 PM, <nfullagar@google.com> wrote:

>
> http://codereview.chromium.**org/8678028/diff/1/ppapi/**
>
native_client/src/shared/**ppapi_proxy/plugin_ppb_**graphics_3d.cc<http://codereview.chromium.org/8678028/diff/1/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc>
> File
> ppapi/native_client/src/**shared/ppapi_proxy/plugin_ppb_**graphics_3d.cc
> (right):
>
> http://codereview.chromium.**org/8678028/diff/1/ppapi/**
> native_client/src/shared/**ppapi_proxy/plugin_ppb_**
>
graphics_3d.cc#newcode245<http://codereview.chromium.org/8678028/diff/1/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc#newcode245>
> ppapi/native_client/src/**shared/ppapi_proxy/plugin_ppb_**
> graphics_3d.cc:245:
> impl()->SwapBuffers();
> what's going to happen if the NaClSrpcError retval returns an error
> below?  There will be a pending impl()->SwapBuffer() but the RPC failed?
>
>
http://codereview.chromium.**org/8678028/<http://codereview.chromium.org/8678...
>

[commit-bot: I haz the power, 2011-11-23 23:58:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/8678028/1

[commit-bot: I haz the power, 2011-11-24 01:06:24]

Change committed as 111465