Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/integers.cc

Issue 8678025: Fix crashes when going to natives. Throw an exception instead. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/double.cc ('k') | runtime/lib/math.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/integers.cc
===================================================================
--- runtime/lib/integers.cc (revision 1815)
+++ runtime/lib/integers.cc (working copy)
@@ -159,7 +159,7 @@
DEFINE_NATIVE_ENTRY(Integer_bitAndFromInteger, 2) {
const Integer& right = Integer::CheckedHandle(arguments->At(0));
- const Integer& left = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
ASSERT(CheckInteger(right));
ASSERT(CheckInteger(left));
if (FLAG_trace_intrinsified_natives) {
@@ -174,7 +174,7 @@
DEFINE_NATIVE_ENTRY(Integer_bitOrFromInteger, 2) {
const Integer& right = Integer::CheckedHandle(arguments->At(0));
- const Integer& left = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
ASSERT(CheckInteger(right));
ASSERT(CheckInteger(left));
if (FLAG_trace_intrinsified_natives) {
@@ -189,7 +189,7 @@
DEFINE_NATIVE_ENTRY(Integer_bitXorFromInteger, 2) {
const Integer& right = Integer::CheckedHandle(arguments->At(0));
- const Integer& left = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
ASSERT(CheckInteger(right));
ASSERT(CheckInteger(left));
if (FLAG_trace_intrinsified_natives) {
@@ -330,7 +330,7 @@
DEFINE_NATIVE_ENTRY(Integer_addFromInteger, 2) {
const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
- const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
ASSERT(CheckInteger(right_int));
ASSERT(CheckInteger(left_int));
if (FLAG_trace_intrinsified_natives) {
@@ -345,7 +345,7 @@
DEFINE_NATIVE_ENTRY(Integer_subFromInteger, 2) {
const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
- const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
ASSERT(CheckInteger(right_int));
ASSERT(CheckInteger(left_int));
if (FLAG_trace_intrinsified_natives) {
@@ -360,7 +360,7 @@
DEFINE_NATIVE_ENTRY(Integer_mulFromInteger, 2) {
const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
- const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
ASSERT(CheckInteger(right_int));
ASSERT(CheckInteger(left_int));
if (FLAG_trace_intrinsified_natives) {
@@ -375,7 +375,7 @@
DEFINE_NATIVE_ENTRY(Integer_truncDivFromInteger, 2) {
const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
- const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
ASSERT(CheckInteger(right_int));
ASSERT(CheckInteger(left_int));
ASSERT(!right_int.IsZero());
@@ -387,7 +387,7 @@
DEFINE_NATIVE_ENTRY(Integer_moduloFromInteger, 2) {
const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
- const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
ASSERT(CheckInteger(right_int));
ASSERT(CheckInteger(right_int));
if (FLAG_trace_intrinsified_natives) {
@@ -406,7 +406,7 @@
DEFINE_NATIVE_ENTRY(Integer_greaterThanFromInteger, 2) {
const Integer& right = Integer::CheckedHandle(arguments->At(0));
- const Integer& left = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
ASSERT(CheckInteger(right));
ASSERT(CheckInteger(left));
if (FLAG_trace_intrinsified_natives) {
@@ -420,7 +420,7 @@
DEFINE_NATIVE_ENTRY(Integer_equalToInteger, 2) {
const Integer& left = Integer::CheckedHandle(arguments->At(0));
- const Integer& right = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, right, arguments->At(1));
ASSERT(CheckInteger(left));
ASSERT(CheckInteger(right));
if (FLAG_trace_intrinsified_natives) {
@@ -528,7 +528,7 @@
DEFINE_NATIVE_ENTRY(Smi_sarFromInt, 2) {
const Smi& amount = Smi::CheckedHandle(arguments->At(0));
- const Integer& value = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, value, arguments->At(1));
ASSERT(CheckInteger(amount));
ASSERT(CheckInteger(value));
Integer& result = Integer::Handle(
@@ -540,7 +540,7 @@
DEFINE_NATIVE_ENTRY(Smi_shlFromInt, 2) {
const Smi& amount = Smi::CheckedHandle(arguments->At(0));
- const Integer& value = Integer::CheckedHandle(arguments->At(1));
+ GET_NATIVE_ARGUMENT(Integer, value, arguments->At(1));
ASSERT(CheckInteger(amount));
ASSERT(CheckInteger(value));
if (FLAG_trace_intrinsified_natives) {
« no previous file with comments | « runtime/lib/double.cc ('k') | runtime/lib/math.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698