Fix crashes when going to natives. Throw an exception instead.

runtime/lib/math.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <ctype.h>  // isspace.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/random.h"
 #include "vm/scanner.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(MathNatives_sqrt, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(sqrt(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(sqrt(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_sin, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(sin(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(sin(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_cos, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(cos(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(cos(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_tan, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(tan(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(tan(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_asin, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(asin(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(asin(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_acos, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(acos(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(acos(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_atan, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(atan(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(atan(operand.value()))));
 }
 
 // It is not possible to call the native MathNatives_atan2. Somehow this leads
 // to a dynamic error "native function 'MathNatives_atan2' cannot be found".
 DEFINE_NATIVE_ENTRY(MathNatives_2atan, 2) {
-  const double operand1 = Double::CheckedHandle(arguments->At(0)).value();
-  const double operand2 = Double::CheckedHandle(arguments->At(1)).value();
-  arguments->SetReturn(Double::Handle(Double::New(atan2(operand1, operand2))));
+  GET_NATIVE_ARGUMENT(Double, operand1, arguments->At(0));
+  GET_NATIVE_ARGUMENT(Double, operand2, arguments->At(1));
+  arguments->SetReturn(Double::Handle(Double::New(
+      atan2(operand1.value(), operand2.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_exp, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(exp(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(exp(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_log, 1) {
-  const double operand = Double::CheckedHandle(arguments->At(0)).value();
-  arguments->SetReturn(Double::Handle(Double::New(log(operand))));
+  GET_NATIVE_ARGUMENT(Double, operand, arguments->At(0));
+  arguments->SetReturn(Double::Handle(Double::New(log(operand.value()))));
 }
 
 DEFINE_NATIVE_ENTRY(MathNatives_random, 0) {
   arguments->SetReturn(Double::Handle(Double::
       New(static_cast<double>(Random::RandomInt32()-1)/0x80000000)));
 }
 
 
 // TODO(srdjan): Investigate for performance hit; the integer and double parsing
 // may not be efficient as we need to generate two extra growable arrays.
@@ skipping 18 matching lines @@
     }
     *is_positive = tokens[0].kind == Token::kADD;
     *value = tokens[1].literal;
     return true;
   }
   return false;
 }
 
 
 DEFINE_NATIVE_ENTRY(MathNatives_parseInt, 1) {
-  const String& value = String::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(String, value, arguments->At(0));
   Scanner scanner(value, String::Handle());
   const Scanner::GrowableTokenStream& tokens = scanner.GetStream();
   String* int_string;
   bool is_positive;
   if (IsValidLiteral(tokens, Token::kINTEGER, &is_positive, &int_string)) {
     Integer& result = Integer::Handle();
     if (is_positive) {
       result = Integer::New(*int_string);
     } else {
       String& temp = String::Handle();
       temp = String::Concat(String::Handle(String::NewSymbol("-")),
                             *int_string);
       result = Integer::New(temp);
     }
     arguments->SetReturn(result);
   } else {
     GrowableArray<const Object*> args;
     args.Add(&value);
     Exceptions::ThrowByType(Exceptions::kBadNumberFormat, args);
   }
 }
 
 
 DEFINE_NATIVE_ENTRY(MathNatives_parseDouble, 1) {
-  const String& value = String::CheckedHandle(arguments->At(0));
+  GET_NATIVE_ARGUMENT(String, value, arguments->At(0));
   Scanner scanner(value, String::Handle());
   const Scanner::GrowableTokenStream& tokens = scanner.GetStream();
   String* number_string;
   bool is_positive;
   if (IsValidLiteral(tokens, Token::kDOUBLE, &is_positive, &number_string)) {
     const char* cstr = number_string->ToCString();
     char* p_end = NULL;
     double double_value = strtod(cstr, &p_end);
     ASSERT(p_end != cstr);
     if (!is_positive) {
@@ skipping 29 matching lines @@
       return;
     }
   }
 
   GrowableArray<const Object*> args;
   args.Add(&value);
   Exceptions::ThrowByType(Exceptions::kBadNumberFormat, args);
 }
 
 }  // namespace dart