Fix crashes when going to natives. Throw an exception instead.

runtime/lib/integers.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
@@ skipping 141 matching lines @@
     Mint& mint = Mint::Handle();
     mint ^= i.raw();
     return !Smi::IsValid64(mint.value());
   }
   return true;
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_bitAndFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitAndFromInteger %s & %s\n",
         right.ToCString(), left.ToCString());
   }
   Integer& result = Integer::Handle(
       IntegerBitOperation(Token::kBIT_AND, left, right));
   arguments->SetReturn(Integer::Handle(AsInteger(result)));
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_bitOrFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitOrFromInteger %s | %s\n",
         left.ToCString(), right.ToCString());
   }
   Integer& result = Integer::Handle(
       IntegerBitOperation(Token::kBIT_OR, left, right));
   arguments->SetReturn(Integer::Handle(AsInteger(result)));
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_bitXorFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_bitXorFromInteger %s ^ %s\n",
         left.ToCString(), right.ToCString());
   }
   Integer& result = Integer::Handle(
       IntegerBitOperation(Token::kBIT_XOR, left, right));
   arguments->SetReturn(Integer::Handle(AsInteger(result)));
 }
@@ skipping 120 matching lines @@
   const Bigint& left_big = Bigint::Handle(AsBigint(left_int));
   const Bigint& right_big = Bigint::Handle(AsBigint(right_int));
   const Bigint& result =
       Bigint::Handle(BinaryOpWithTwoBigints(operation, left_big, right_big));
   return Integer::Handle(AsInteger(result)).raw();
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_addFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_addFromInteger %s + %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   const Integer& result =
       Integer::Handle(IntegerBinopHelper(Token::kADD, left_int, right_int));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_subFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_subFromInteger %s - %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   const Integer& result =
       Integer::Handle(IntegerBinopHelper(Token::kSUB, left_int, right_int));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_mulFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_mulFromInteger %s * %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   const Integer& result =
       Integer::Handle(IntegerBinopHelper(Token::kMUL, left_int, right_int));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_truncDivFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(left_int));
   ASSERT(!right_int.IsZero());
   const Integer& result = Integer::Handle(
       IntegerBinopHelper(Token::kTRUNCDIV, left_int, right_int));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_moduloFromInteger, 2) {
   const Integer& right_int = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left_int = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left_int, arguments->At(1));
   ASSERT(CheckInteger(right_int));
   ASSERT(CheckInteger(right_int));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_moduloFromInteger %s mod %s\n",
         left_int.ToCString(), right_int.ToCString());
   }
   if (right_int.IsZero()) {
     // Should have been caught before calling into runtime.
     UNIMPLEMENTED();
   }
   const Integer& result =
       Integer::Handle(IntegerBinopHelper(Token::kMOD, left_int, right_int));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_greaterThanFromInteger, 2) {
   const Integer& right = Integer::CheckedHandle(arguments->At(0));
-  const Integer& left = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, left, arguments->At(1));
   ASSERT(CheckInteger(right));
   ASSERT(CheckInteger(left));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_greaterThanFromInteger %s > %s\n",
         left.ToCString(), right.ToCString());
   }
   const Bool& result = Bool::Handle(Bool::Get(left.CompareWith(right) == 1));
   arguments->SetReturn(result);
 }
 
 
 DEFINE_NATIVE_ENTRY(Integer_equalToInteger, 2) {
   const Integer& left = Integer::CheckedHandle(arguments->At(0));
-  const Integer& right = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, right, arguments->At(1));
   ASSERT(CheckInteger(left));
   ASSERT(CheckInteger(right));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_equalToInteger %s == %s\n",
         left.ToCString(), right.ToCString());
   }
   const Bool& result = Bool::Handle(Bool::Get(left.CompareWith(right) == 0));
   arguments->SetReturn(result);
 }
 
@@ skipping 87 matching lines @@
       return BigintOperations::ShiftRight(big_value, amount.Value());
     default:
       UNIMPLEMENTED();
   }
   return Integer::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Smi_sarFromInt, 2) {
   const Smi& amount = Smi::CheckedHandle(arguments->At(0));
-  const Integer& value = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, value, arguments->At(1));
   ASSERT(CheckInteger(amount));
   ASSERT(CheckInteger(value));
   Integer& result = Integer::Handle(
       ShiftOperationHelper(Token::kSAR, value, amount));
   arguments->SetReturn(Integer::Handle(AsInteger(result)));
 }
 
 
 
 DEFINE_NATIVE_ENTRY(Smi_shlFromInt, 2) {
   const Smi& amount = Smi::CheckedHandle(arguments->At(0));
-  const Integer& value = Integer::CheckedHandle(arguments->At(1));
+  GET_NATIVE_ARGUMENT(Integer, value, arguments->At(1));
   ASSERT(CheckInteger(amount));
   ASSERT(CheckInteger(value));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Smi_shlFromInt: %s << %s\n",
         value.ToCString(), amount.ToCString());
   }
   Integer& result = Integer::Handle(
       ShiftOperationHelper(Token::kSHL, value, amount));
   arguments->SetReturn(Integer::Handle(AsInteger(result)));
 }
@@ skipping 25 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Bigint_bitNegate, 1) {
   const Bigint& value = Bigint::CheckedHandle(arguments->At(0));
   const Bigint& result = Bigint::Handle(BigintOperations::BitNot(value));
   ASSERT(CheckInteger(value));
   ASSERT(CheckInteger(result));
   arguments->SetReturn(Integer::Handle(AsInteger(result)));
 }
 
 }  // namespace dart