Fix crashes when going to natives. Throw an exception instead.

runtime/lib/byte_buffer.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/assembler.h"
 #include "vm/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(ByteBuffer_allocate, 1) {
-  const Instance& length_instance = Instance::CheckedHandle(arguments->At(0));
-  if (!length_instance.IsSmi()) {
-    GrowableArray<const Object*> args;
-    args.Add(&length_instance);
-    Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
-  }
-  Smi& length = Smi::Handle();
-  length ^= length_instance.raw();
+  GET_NATIVE_ARGUMENT(Smi, length, arguments->At(0));
   if (length.Value() < 0) {
     GrowableArray<const Object*> args;
     args.Add(&length);
     Exceptions::ThrowByType(Exceptions::kIllegalArgument, args);
   }
   uint8_t* data = new uint8_t[length.Value()];
   memset(data, 0, length.Value());
   const ByteBuffer& new_array =
       ByteBuffer::Handle(ByteBuffer::New(data, length.Value()));
   arguments->SetReturn(new_array);
 }
 
 
 DEFINE_NATIVE_ENTRY(ByteBuffer_getLength, 1) {
   const ByteBuffer& array = ByteBuffer::CheckedHandle(arguments->At(0));
-  if (array.IsNull()) {
-    // TODO(asiva): Need to handle error cases.
-    UNIMPLEMENTED();
-    return;
-  }
   const Smi& length = Smi::Handle(Smi::New(array.Length()));
   arguments->SetReturn(length);
 }
 
 
 template<typename ValueType, typename ObjectType>
 static void GetIndexed(NativeArguments* arguments) {
   const ByteBuffer& buffer = ByteBuffer::CheckedHandle(arguments->At(0));
   const Instance& index_instance = Instance::CheckedHandle(arguments->At(1));
   if (!index_instance.IsSmi()) {
@@ skipping 182 matching lines @@
 DEFINE_NATIVE_ENTRY(ByteBuffer_getFloat64, 2) {
   GetIndexed<double, Double>(arguments);
 }
 
 
 DEFINE_NATIVE_ENTRY(ByteBuffer_setFloat64, 3) {
   SetIndexed<double, Double>(arguments);
 }
 
 }  // namespace dart