Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8678023: Fix python scripts in src/tools/ (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix python scripts in src/tools/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. TBR=timurrrr@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111960

Patch Set 1 #

Patch Set 2 : . #

Total comments: 10

Patch Set 3 : updates #

Patch Set 4 : fixes #

Total comments: 3

Patch Set 5 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -551 lines) Patch
M tools/bisect-builds.py View 1 2 5 chunks +5 lines, -1 line 0 comments Download
M tools/checkdeps/checkdeps.py View 1 2 6 chunks +14 lines, -7 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 7 chunks +12 lines, -9 lines 0 comments Download
M tools/clang/scripts/update.py View 1 2 2 chunks +12 lines, -6 lines 0 comments Download
M tools/code_coverage/coverage.py View 1 2 3 4 5 chunks +1 line, -5 lines 0 comments Download
M tools/code_coverage/croc.py View 1 2 3 2 chunks +1 line, -29 lines 0 comments Download
M tools/code_coverage/croc_html.py View 1 2 3 2 chunks +3 lines, -31 lines 0 comments Download
M tools/code_coverage/croc_scan.py View 1 2 3 1 chunk +3 lines, -30 lines 0 comments Download
M tools/code_coverage/croc_scan_test.py View 1 2 3 2 chunks +4 lines, -36 lines 0 comments Download
M tools/code_coverage/croc_test.py View 1 2 3 6 chunks +4 lines, -39 lines 0 comments Download
M tools/code_coverage/process_coverage.py View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M tools/coverity/coverity.py View 8 chunks +14 lines, -7 lines 0 comments Download
M tools/crx_id/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/crx_id/crx_id.py View 1 2 4 chunks +7 lines, -3 lines 0 comments Download
M tools/dromaeo_benchmark_runner/dromaeo_benchmark_runner.py View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M tools/export_tarball/export_tarball.py View 1 2 5 chunks +6 lines, -1 line 0 comments Download
M tools/export_tarball/export_v8_tarball.py View 1 2 5 chunks +8 lines, -3 lines 0 comments Download
A tools/flakiness/find_flakiness.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/gdb/gdb_chrome.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/generate_stubs/generate_stubs.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/generate_stubs/generate_stubs_unittest.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/git/for-all-touched-files.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/gypv8sh.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/heapcheck/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/heapcheck/chrome_tests.py View 1 3 chunks +7 lines, -9 lines 0 comments Download
M tools/heapcheck/heapcheck_test.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/heapcheck/suppressions.py View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M tools/include_tracer.py View 1 2 chunks +17 lines, -10 lines 0 comments Download
M tools/licenses.py View 4 chunks +12 lines, -5 lines 0 comments Download
M tools/linux/dump-static-initializers.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/net/netlog.py View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M tools/nocompile_driver.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf_expectations/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/playback_benchmark/playback_driver.py View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/playback_benchmark/proxy_handler.py View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/playback_benchmark/run.py View 4 chunks +9 lines, -4 lines 0 comments Download
M tools/pragmaonce/pragmaonce.py View 2 chunks +11 lines, -6 lines 0 comments Download
M tools/python/google/gethash_timer.py View 1 2 5 chunks +26 lines, -21 lines 0 comments Download
M tools/python/google/httpd_utils.py View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M tools/python/google/logging_utils.py View 2 chunks +1 line, -5 lines 0 comments Download
M tools/python/google/path_utils.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M tools/python/google/platform_utils.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/python/google/platform_utils_linux.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/python/google/platform_utils_mac.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/python/google/platform_utils_win.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M tools/site_compare/command_line.py View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M tools/site_compare/commands/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/site_compare/commands/compare2.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/site_compare/commands/maskmaker.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/site_compare/commands/measure.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/site_compare/commands/scrape.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/site_compare/commands/timeload.py View 3 chunks +3 lines, -5 lines 0 comments Download
M tools/site_compare/drivers/__init__.py View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/site_compare/drivers/win32/keyboard.py View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M tools/site_compare/drivers/win32/mouse.py View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M tools/site_compare/drivers/win32/windowing.py View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M tools/site_compare/operators/__init__.py View 2 chunks +3 lines, -6 lines 0 comments Download
M tools/site_compare/operators/equals.py View 2 chunks +1 line, -5 lines 0 comments Download
M tools/site_compare/operators/equals_with_mask.py View 2 chunks +1 line, -5 lines 0 comments Download
M tools/site_compare/scrapers/__init__.py View 2 chunks +5 lines, -6 lines 0 comments Download
M tools/site_compare/scrapers/chrome/__init__.py View 2 chunks +6 lines, -8 lines 0 comments Download
M tools/site_compare/scrapers/chrome/chrome011010.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/site_compare/scrapers/chrome/chrome01970.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/site_compare/scrapers/chrome/chromebase.py View 1 2 4 chunks +9 lines, -3 lines 0 comments Download
M tools/site_compare/scrapers/firefox/__init__.py View 2 chunks +5 lines, -8 lines 0 comments Download
M tools/site_compare/scrapers/firefox/firefox2.py View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M tools/site_compare/scrapers/ie/__init__.py View 2 chunks +6 lines, -9 lines 0 comments Download
M tools/site_compare/scrapers/ie/ie7.py View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M tools/site_compare/site_compare.py View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M tools/site_compare/utils/__init__.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/site_compare/utils/browser_iterate.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/sort-headers.py View 3 chunks +4 lines, -3 lines 0 comments Download
M tools/swig/swig.py View 2 chunks +3 lines, -4 lines 0 comments Download
M tools/symsrc/img_fingerprint.py View 1 2 1 chunk +15 lines, -9 lines 0 comments Download
M tools/symsrc/pdb_fingerprint_from_img.py View 1 2 3 4 3 chunks +13 lines, -6 lines 0 comments Download
M tools/symsrc/source_index.py View 1 2 3 4 7 chunks +14 lines, -4 lines 0 comments Download
M tools/sync-webkit-git.py View 1 2 10 chunks +11 lines, -1 line 0 comments Download
A tools/traceline/traceline/scripts/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/traceline/traceline/scripts/alloc.py View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M tools/traceline/traceline/scripts/crit_sec.py View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M tools/traceline/traceline/scripts/filter_short.py View 1 2 2 chunks +16 lines, -5 lines 0 comments Download
M tools/traceline/traceline/scripts/filter_split.sh View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M tools/traceline/traceline/scripts/scstats.py View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M tools/traceline/traceline/scripts/split.py View 1 2 1 chunk +23 lines, -17 lines 0 comments Download
M tools/traceline/traceline/scripts/syscalls.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/unused-symbols-report.py View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M tools/valgrind/asan/asan_test.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/asan/chrome_tests.py View 3 chunks +8 lines, -12 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 3 chunks +4 lines, -6 lines 0 comments Download
A tools/valgrind/common.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/valgrind/drmemory_analyze.py View 1 2 2 chunks +13 lines, -8 lines 0 comments Download
M tools/valgrind/gdb_helper.py View 2 chunks +6 lines, -6 lines 0 comments Download
A tools/valgrind/memcheck/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/valgrind/memcheck_analyze.py View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M tools/valgrind/suppressions.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/tsan/PRESUBMIT.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/tsan_analyze.py View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
A tools/win/supalink/check_installed.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/win/supalink/install_supalink.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
M-A Ruel
(It's a shame traceline hasn't been used for years) Timur, you won the git blame ...
9 years ago (2011-11-23 21:33:55 UTC) #1
Alexander Potapenko
Some drive-by comments. Overall: because you've done this for most of the files, can you ...
9 years ago (2011-11-24 07:53:01 UTC) #2
M-A Ruel
ptal http://codereview.chromium.org/8678023/diff/2001/tools/code_coverage/croc_html.py File tools/code_coverage/croc_html.py (right): http://codereview.chromium.org/8678023/diff/2001/tools/code_coverage/croc_html.py#newcode1 tools/code_coverage/croc_html.py:1: # Copyright 2011, Google Inc. On 2011/11/24 07:53:02, ...
9 years ago (2011-11-27 21:26:02 UTC) #3
Timur Iskhodzhanov
Deferring this to glider@ :) On 2011/11/27 21:26:02, Marc-Antoine Ruel wrote: > ptal > > ...
9 years ago (2011-11-27 21:36:43 UTC) #4
Alexander Potapenko
Looks almost good. In some files main() may return None, but since sys.exit(None) is equal ...
9 years ago (2011-11-28 10:29:35 UTC) #5
M-A Ruel
Thanks! updated.
9 years ago (2011-11-28 16:34:59 UTC) #6
Alexander Potapenko
On 2011/11/28 16:34:59, Marc-Antoine Ruel wrote: > Thanks! updated. LGTM
9 years ago (2011-11-28 17:45:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8678023/12020
9 years ago (2011-11-29 15:34:06 UTC) #8
commit-bot: I haz the power
Presubmit check for 8678023-12020 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-29 15:34:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8678023/12020
9 years ago (2011-11-29 15:37:01 UTC) #10
commit-bot: I haz the power
9 years ago (2011-11-29 17:25:36 UTC) #11 
Change committed as 111960

Powered by Google App Engine
This is Rietveld 408576698