Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 8678022: Fix python scripts in src/webkit (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
8 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix python scripts in src/webkit Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. TBR=dpranke@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116864

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : Removed stale scripts #

Patch Set 5 : Removing run_node_leak_test.py too since it's a test_shell wrapper #

Patch Set 6 : Rebase against HEAD #

Patch Set 7 : 2012 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -374 lines) Patch
M webkit/build/webkit_version.py View 1 3 chunks +6 lines, -3 lines 0 comments Download
D webkit/data/dom_serializer/dummy.exe View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/support/setup_third_party.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A webkit/tools/layout_tests/run_http_server.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/tools/leak_tests/run_node_leak_test.py View 1 2 3 4 1 chunk +0 lines, -279 lines 0 comments Download
D webkit/tools/leak_tests/test_lists/alexa_100.txt View 1 2 3 4 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
M-A Ruel
(I won't be able to use the CQ because of a few files using webkit ...
9 years, 1 month ago (2011-11-23 20:23:06 UTC) #1
Dirk Pranke
lgtm, but I bet we can delete a bunch of these files. http://codereview.chromium.org/8678022/diff/2001/webkit/tools/layout_tests/webkitpy/layout_tests/expectations_line.py File webkit/tools/layout_tests/webkitpy/layout_tests/expectations_line.py ...
9 years, 1 month ago (2011-11-23 21:29:15 UTC) #2
M-A Ruel
On 2011/11/23 21:29:15, Dirk Pranke wrote: > lgtm, but I bet we can delete a ...
9 years, 1 month ago (2011-11-23 21:33:04 UTC) #3
ojan
On 2011/11/23 21:33:04, Marc-Antoine Ruel wrote: > On 2011/11/23 21:29:15, Dirk Pranke wrote: > > ...
9 years ago (2011-11-28 18:32:44 UTC) #4
M-A Ruel
On 2011/11/28 18:32:44, ojan wrote: > You can definitely delete the webkitpy/layout_tests files. I'm less ...
9 years ago (2011-11-29 15:40:39 UTC) #5
Dirk Pranke
did this land? if not, is there a reason it didn't?
8 years, 11 months ago (2012-01-04 20:52:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8678022/13001
8 years, 11 months ago (2012-01-09 13:04:52 UTC) #7
commit-bot: I haz the power
Presubmit check for 8678022-13001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-09 13:04:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8678022/13001
8 years, 11 months ago (2012-01-09 13:06:02 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-09 14:48:47 UTC) #10
Change committed as 116864

Powered by Google App Engine
This is Rietveld 408576698