Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8678015: Touch constants and dead code removal. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, robertshield, kkania, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Touch constants and dead code removal. BUG=105046 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111415

Patch Set 1 #

Total comments: 1

Patch Set 2 : Applied Sadrul's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -655 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download
D chrome/browser/ui/touch/frame/browser_non_client_frame_view_factory_touch.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/touch/frame/touch_browser_frame_view.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/touch/frame/touch_browser_frame_view.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/touch/tabs/tab_strip_factory.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab_strip.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab_strip.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab_strip_controller.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab_strip_controller.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/ui/touch/tabs/touch_tab_strip_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Sadrul, Can you please review this CL? Thanks, -- Emmanuel
9 years, 1 month ago (2011-11-23 17:26:05 UTC) #1
sadrul
LGTM This change removes the use of a TOUCH_UI specific API change in ActiveDownloadsUI (in ...
9 years, 1 month ago (2011-11-23 19:06:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8678015/1021
9 years, 1 month ago (2011-11-23 19:29:07 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 21:42:35 UTC) #4 
Change committed as 111415

Powered by Google App Engine
This is Rietveld 408576698