Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 8678014: Reenabling a test that was failing because of EOL. (Closed)

Created:
9 years, 1 month ago by Jay Civelli
Modified:
9 years, 1 month ago
Reviewers:
jcivelli, jam, M-A Ruel, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Reenabling a test that was failing because it loads a MHTML file that requires CRLFs and when landed from Linux they would be converted to CRs. TBR=maruel BUG=None TEST=RenderViewHostTest.BaseURLParam should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jay Civelli
9 years, 1 month ago (2011-11-23 16:50:25 UTC) #1
M-A Ruel
lgtm
9 years, 1 month ago (2011-11-23 16:51:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8678014/1
9 years, 1 month ago (2011-11-23 21:09:50 UTC) #3
commit-bot: I haz the power
Presubmit check for 8678014-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-23 21:09:52 UTC) #4
jcivelli
Scott, Could you review this CL? (I need an OWNER approval...) Thanks.
9 years, 1 month ago (2011-11-23 21:17:30 UTC) #5
Jay Civelli
John, Could you review this CL? I need an owner's review so I can land ...
9 years, 1 month ago (2011-11-23 21:45:16 UTC) #6
M-A Ruel
On 2011/11/23 21:45:16, Jay Civelli wrote: > John, Don't bother, problem worked around.
9 years, 1 month ago (2011-11-23 21:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8678014/1
9 years, 1 month ago (2011-11-23 21:49:29 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 23:40:13 UTC) #9
Change committed as 111445

Powered by Google App Engine
This is Rietveld 408576698