Issue 8677030: base::Bind: Convert more of chrome/browser/sessions.

Issue 8677030: base::Bind: Convert more of chrome/browser/sessions. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert more of chrome/browser/sessions. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111489

Patch Set 3 : Build fix. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -39 lines)			Patch
M	chrome/browser/sessions/base_session_service.h	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/sessions/base_session_service.cc	View		7 chunks	+21 lines, -16 lines	0 comments	Download
M	chrome/browser/sessions/session_backend.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/sessions/session_service.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sessions/session_service.cc	View	1	6 chunks	+17 lines, -11 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm w/ nits http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/base_session_service.h File chrome/browser/sessions/base_session_service.h (right): http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/base_session_service.h#newcode10 chrome/browser/sessions/base_session_service.h:10: #include "base/callback_old.h" change to callback.h http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/session_service.cc ...

9 years, 1 month ago (2011-11-24 00:01:04 UTC) #2

James Hawkins

9 years, 1 month ago (2011-11-24 00:15:36 UTC) #3

http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/base_se...
File chrome/browser/sessions/base_session_service.h (right):

http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/base_se...
chrome/browser/sessions/base_session_service.h:10: #include
"base/callback_old.h"
On 2011/11/24 00:01:04, csilv wrote:
> change to callback.h

Done.

http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/session...
File chrome/browser/sessions/session_service.cc (right):

http://codereview.chromium.org/8677030/diff/1/chrome/browser/sessions/session...
chrome/browser/sessions/session_service.cc:12: #include "base/bind.h"
On 2011/11/24 00:01:04, csilv wrote:
> add bind/bind_helpers.h

Done.

Expand Messages | Collapse Messages