Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Unified Diff: chrome/browser/extensions/extension_info_map.cc

Issue 8677026: Update process sharing rules for hosted and isolated apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_info_map.cc
diff --git a/chrome/browser/extensions/extension_info_map.cc b/chrome/browser/extensions/extension_info_map.cc
index d3210a6f08346a4e77dd9b8c35db2d8f1f36c67c..d48d4e02ada9056f4ca2e33c80ae01ebf22753ed 100644
--- a/chrome/browser/extensions/extension_info_map.cc
+++ b/chrome/browser/extensions/extension_info_map.cc
@@ -108,10 +108,10 @@ bool ExtensionInfoMap::CanCrossIncognito(const Extension* extension) {
void ExtensionInfoMap::RegisterExtensionProcess(const std::string& extension_id,
int process_id) {
- if (!process_map_.Insert(extension_id, process_id)) {
- NOTREACHED() << "Duplicate extension process registration for: "
- << extension_id << "," << process_id << ".";
Charlie Reis 2011/11/23 23:46:54 aa: I was hitting this NOTREACHED when loading a s
- }
+ // An extension may be added multiple times for the same process, such as
+ // multiple instances of the same hosted app once the process limit is
+ // reached.
+ process_map_.Insert(extension_id, process_id);
}
void ExtensionInfoMap::UnregisterExtensionProcess(

Powered by Google App Engine
This is Rietveld 408576698