Update process sharing rules for hosted and isolated apps.

Update process sharing rules for hosted and isolated apps.
Hosted apps should only share with each other, and an isolated app should
only share with the exact same app.

BUG=102533
BUG=105322
TEST=Open many pages, extensions, and apps, and check sharing relationships.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113043

[Charlie Reis, 2011-11-23 23:46:54]

Albert, can you review everything but the ExtensionInfoMap issue?

Aaron, this is where I'm running into the ProcessMap problem from
http://crbug.com/105328.  The test fails because two copies of the isolated app
end up in the same process.

http://codereview.chromium.org/8677026/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_info_map.cc (left):

http://codereview.chromium.org/8677026/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_info_map.cc:113: << extension_id << "," <<
process_id << ".";
aa: I was hitting this NOTREACHED when loading a second instance of the same
hosted app.  This will usually go into a new process, but it may share a process
if we're over the limit.

I've filed http://crbug.com/105328 to figure out the right solution, since this
won't work.

[awong, 2011-11-24 00:03:49]

LGTM for non-extension-map w/ nits

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:231:
extension->is_storage_isolated())
nit: check is_storage_isolated() first.  Might as well do the O(1) test earlier.

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:447: // An isolated app is only
allowed to share with the exact same app.
Add short sentence for why?

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:451: return
IsIsolatedAppInProcess(site_url, process_host, process_map, service);
Sad that we have to double-iterate the extension map, but oh well.

[Charlie Reis, 2011-11-24 00:26:45]

New patch uploaded.  Still need to figure out how to handle ExtensionInfoMap.

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:231:
extension->is_storage_isolated())
On 2011/11/24 00:03:49, awong wrote:
> nit: check is_storage_isolated() first.  Might as well do the O(1) test
earlier.

Done.

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:447: // An isolated app is only
allowed to share with the exact same app.
On 2011/11/24 00:03:49, awong wrote:
> Add short sentence for why?

Done.

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:451: return
IsIsolatedAppInProcess(site_url, process_host, process_map, service);
On 2011/11/24 00:03:49, awong wrote:
> Sad that we have to double-iterate the extension map, but oh well.

We don't, do we?  We either iterate it in IsIsolatedAppInProcess or in
GetProcessPrivilege, but not both.

[awong, 2011-11-24 00:31:28]

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8677026/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:451: return
IsIsolatedAppInProcess(site_url, process_host, process_map, service);
On 2011/11/24 00:26:45, creis wrote:
> On 2011/11/24 00:03:49, awong wrote:
> > Sad that we have to double-iterate the extension map, but oh well.
> 
> We don't, do we?  We either iterate it in IsIsolatedAppInProcess or in
> GetProcessPrivilege, but not both.

You're right...I'm just mis-reading.

[Charlie Reis, 2011-12-05 17:25:00]

I've merged this with tip-of-tree and removed the change to ExtensionInfoMap
since Aaron's fix for http://crbug.com/105328 has landed.  Will land soon.