Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 8677025: Reverting based on discussions on #chromium with shess and rsleevi (Closed)

Created:
9 years, 1 month ago by Jamie
Modified:
9 years, 1 month ago
Reviewers:
brettw, Ryan Sleevi
CC:
chromium-reviews, James Su, brettw-cc_chromium.org
Visibility:
Public.

Description

Reverting based on discussions on #chromium with shess and rsleevi Revert 111386 - Add a field trial for using lower sqlite cache sizes. There are a few relevant histograms that I annotated with the field trial name, and I added a new AddPage histogram. TEST=none BUG=none Review URL: http://codereview.chromium.org/8379009 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -109 lines) Patch
M chrome/browser/autocomplete/history_url_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 5 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/history/history_database.cc View 2 chunks +5 lines, -10 lines 0 comments Download
D chrome/browser/history/history_field_trial.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/history/history_field_trial.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/history/in_memory_database.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/history/text_database.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jamie
9 years, 1 month ago (2011-11-23 23:04:36 UTC) #1
Ryan Sleevi
9 years, 1 month ago (2011-11-23 23:16:14 UTC) #2
Sample Failures:
http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28dbg%29%28sha...
(browser_tests, ui_tests)

http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28dbg%29%281%2...
(browser_tests)

Sample suspicious stacktrace:
Note: Google Test filter = PrerenderBrowserTest.PrerenderInfiniteLoop
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PrerenderBrowserTest, where TypeParam = 
[ RUN      ] PrerenderBrowserTest.PrerenderInfiniteLoop
[17589:17589:1123/125318:1331761186:WARNING:zygote_host_linux.cc(149)] Running
without the SUID sandbox! See
http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more
information on developing with the sandbox on.
[17589:17592:1123/125318:1331766136:ERROR:object_proxy.cc(237)] Failed to call
method: org.freedesktop.DBus.Error.ServiceUnknown: The name
org.freedesktop.NetworkManager was not provided by any .service files
[17589:17592:1123/125318:1331766510:WARNING:network_change_notifier_linux.cc(168)]
No response received for initial state request
[17589:17607:1123/125318:1331828558:FATAL:weak_ptr.cc(21)] Check failed:
thread_checker_.CalledOnValidThread(). 
Backtrace:
	base::debug::StackTrace::StackTrace() [0x90c2aac]
	logging::LogMessage::~LogMessage() [0x90e8a21]
	base::internal::WeakReference::Flag::IsValid() [0x90eadfb]
	base::internal::WeakReference::is_valid() [0x90eaefe]
	base::WeakPtr<>::get() [0x90b77a5]
	base::WeakPtr<>::operator->() [0x90b6660]
	ObserverListBase<>::Iterator::Iterator() [0x90b5c7b]
	base::FieldTrialList::NotifyFieldTrialGroupSelection() [0x90b5330]
	base::FieldTrial::group() [0x90b3ac9]
	history::HistoryFieldTrial::Activate() [0x86493e5]
	history::HistoryBackend::InitImpl() [0x86315a6]
	history::HistoryBackend::Init() [0x862fc84]
	base::internal::RunnableAdapter<>::Run() [0x862b819]
	base::internal::InvokeHelper<>::MakeItSo() [0x862a0f2]
	base::internal::Invoker<>::Run() [0x862855f]
	base::Callback<>::Run() [0x85c2a3c]
	MessageLoop::RunTask() [0x90edf7c]
	MessageLoop::DeferOrRunPendingTask() [0x90ee077]
	MessageLoop::DoWork() [0x90ee883]
	base::MessagePumpDefault::Run() [0x90f670c]
	MessageLoop::RunInternal() [0x90edc1d]
	MessageLoop::RunHandler() [0x90edaf7]
	MessageLoop::Run() [0x90ed42f]
	base::Thread::Run() [0x9130229]
	base::Thread::ThreadMain() [0x91303bf]
	base::(anonymous namespace)::ThreadFunc() [0x912efb6]
	start_thread [0xb747396e]
	0xb66a0a4e

[17589:17607:1123/125318:1331828558:FATAL:weak_ptr.cc(21)] Check failed:
thread_checker_.CalledOnValidThread(). 
Backtrace:
	base::debug::StackTrace::StackTrace() [0x90c2aac]
	logging::LogMessage::~LogMessage() [0x90e8a21]
	base::internal::WeakReference::Flag::IsValid() [0x90eadfb]
	base::internal::WeakReference::is_valid() [0x90eaefe]
	base::WeakPtr<>::get() [0x90b77a5]
	base::WeakPtr<>::operator->() [0x90b6660]
	ObserverListBase<>::Iterator::Iterator() [0x90b5c7b]
	base::FieldTrialList::NotifyFieldTrialGroupSelection() [0x90b5330]
	base::FieldTrial::group() [0x90b3ac9]
	history::HistoryFieldTrial::Activate() [0x86493e5]
	history::HistoryBackend::InitImpl() [0x86315a6]
	history::HistoryBackend::Init() [0x862fc84]
	base::internal::RunnableAdapter<>::Run() [0x862b819]
	base::internal::InvokeHelper<>::MakeItSo() [0x862a0f2]
	base::internal::Invoker<>::Run() [0x862855f]
	base::Callback<>::Run() [0x85c2a3c]
	MessageLoop::RunTask() [0x90edf7c]
	MessageLoop::DeferOrRunPendingTask() [0x90ee077]
	MessageLoop::DoWork() [0x90ee883]
	base::MessagePumpDefault::Run() [0x90f670c]
	MessageLoop::RunInternal() [0x90edc1d]
	MessageLoop::RunHandler() [0x90edaf7]
	MessageLoop::Run() [0x90ed42f]
	base::Thread::Run() [0x9130229]
	base::Thread::ThreadMain() [0x91303bf]
	base::(anonymous namespace)::ThreadFunc() [0x912efb6]
	start_thread [0xb747396e]
	0xb66a0a4e

[1123/125319:ERROR:process_util_posix.cc(299)] Unable to terminate process group
17589: No such process
Note: Google Test filter = PrerenderBrowserTest.PrerenderInfiniteLoopMultiple

Powered by Google App Engine
This is Rietveld 408576698