Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 8677020: Convert safe_browsing_service_browsertest.cc to base::Bind. (Closed)

Created:
9 years, 1 month ago by Scott Hess - ex-Googler
Modified:
9 years, 1 month ago
Reviewers:
mattm
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert safe_browsing_service_browsertest.cc to base::Bind. NewRunnableMethod() -> base::Bind() for tasks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 7 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Scott Hess - ex-Googler
Last change in safe_browsing except an arity-7 conversion in safe_browsing_service.cc. I've heard that I should ...
9 years, 1 month ago (2011-11-23 20:40:19 UTC) #1
mattm
lgtm
9 years, 1 month ago (2011-11-23 20:52:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/8677020/1
9 years, 1 month ago (2011-11-23 21:17:24 UTC) #3
commit-bot: I haz the power
Try job failure for 8677020-1 (retry) on win_rel for step "base_unittests". It's a second try, ...
9 years, 1 month ago (2011-11-23 23:28:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/8677020/1
9 years, 1 month ago (2011-11-23 23:37:02 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 01:02:27 UTC) #6
Change committed as 111461

Powered by Google App Engine
This is Rietveld 408576698