Issue 8677015: base::Bind: Convert FilePathWatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8677015: base::Bind: Convert FilePathWatcher. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert FilePathWatcher. BUG=none TEST=none R=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111405

Patch Set 1 #

Total comments: 1

Patch Set 2 : Convert browsertest. #

Patch Set 3 : Style fix. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -70 lines)			Patch
M	base/files/file_path_watcher.h	View	1 2	3 chunks	+18 lines, -31 lines	0 comments	Download
M	base/files/file_path_watcher.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/files/file_path_watcher_browsertest.cc	View	1	5 chunks	+15 lines, -37 lines	0 comments	Download
M	base/files/file_path_watcher_linux.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/files/file_path_watcher_win.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 1 month ago (2011-11-23 19:54:13 UTC) #2

lgtm

http://codereview.chromium.org/8677015/diff/1/base/files/file_path_watcher.h
File base/files/file_path_watcher.h (right):

http://codereview.chromium.org/8677015/diff/1/base/files/file_path_watcher.h#...
base/files/file_path_watcher.h:96: static void CancelWatch(const
scoped_refptr<PlatformDelegate>& delegate);
This should come after the constructor/destructor

Expand Messages | Collapse Messages