Issue 8677013: Fix bug preventing pyauto suite CHROMEOS_PERF from running on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8677013: Fix bug preventing pyauto suite CHROMEOS_PERF from running on ChromeOS. (Closed)

Created:
9 years ago by dennis_jeffrey

Modified:
9 years ago

Reviewers:
rohitbm

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix bug preventing pyauto suite CHROMEOS_PERF from running on ChromeOS. A string class variable in netflix.py is named starting with the substring 'test', which is being interpreted as a test case when pauto is invoked with suite CHROMEOS_PERF (since that suite runs perf.py on ChromeOS, which in turn imports from netflix.py). This CL changes the name of that class variable to avoid this problem, and also includes a few minor, related edits. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111391

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	chrome/test/functional/netflix.py	View		3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitbm

9 years ago (2011-11-23 19:25:20 UTC) #2

LGTM

Thanks Dennis for taking care of that.

On 2011/11/23 18:59:17, dennis_jeffrey wrote:

Expand Messages | Collapse Messages