Relax inlining limits for simple leaf functions.

src/hydrogen.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 734 matching lines @@
 
   // Forward declarations for inner scope classes.
   class SubgraphScope;
 
   static const InlineFunctionGenerator kInlineFunctionGenerators[];
 
   static const int kMaxCallPolymorphism = 4;
   static const int kMaxLoadPolymorphism = 4;
   static const int kMaxStorePolymorphism = 4;
 
-  static const int kMaxInlinedNodes = 196;
+
+  // Make sure that kMaxInlinedSize < SharedFunctionInfo::kAstNodeCountMask.

[Kevin Millikin (Chromium), 2011/11/28 12:11:59]

How about:

STATIC_ASSERT(kMaxInlinedSize < SharedFunctionInfo::kAstNodeCountMask);

[ulan, 2011/11/29 14:06:52]

Done.

+  static const int kMaxInlinedNodesSoft = 196;
+  static const int kMaxInlinedNodesHard = 270;

[Kevin Millikin (Chromium), 2011/11/28 12:11:59]

I still don't think these constants are documented very well, here or in the
source.  I suggest something like:

// Hard limits.
static const int kMaxSourceSize = 600;  // Per site.
static const int kMaxInlinedSize = 196;  // Per site.
static const int kMaxInlinedNodesHard = 270;  // Cumulative.

// Soft limits.  After the soft limit is reached we will only inline small
primitives.
static const int kMaxInlinedNodesSoft = 196;  // Cumulative
static const int kMaxInlinedPrimitiveSize = 40;  // Per site.

[ulan, 2011/11/29 14:06:52]

Done.

   static const int kMaxInlinedSize = 196;
+  static const int kMaxInlinedPrimitiveSize = 40;
   static const int kMaxSourceSize = 600;
 
   // Simple accessors.
   void set_function_state(FunctionState* state) { function_state_ = state; }
 
   AstContext* ast_context() const { return ast_context_; }
   void set_ast_context(AstContext* context) { ast_context_ = context; }
 
   // Accessors forwarded to the function state.
   CompilationInfo* info() const {
@@ skipping 483 matching lines @@
   const char* filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_