Issue 8677006: Recommit introducing short external strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8677006: Recommit introducing short external strings. (Closed)

Created:
9 years, 1 month ago by Yang

Modified:
9 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Recommit introducing short external strings. Committed: http://code.google.com/p/v8/source/detail?r=10054

Total comments: 1

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -77 lines)			Patch
M	src/api.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	1 chunk	+8 lines, -9 lines	1 comment	Download
M	src/objects.h	View		10 chunks	+65 lines, -4 lines	0 comments	Download
M	src/objects.cc	View		3 chunks	+27 lines, -34 lines	0 comments	Download
M	src/objects-inl.h	View		3 chunks	+23 lines, -12 lines	0 comments	Download
M	src/objects-printer.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/objects-visiting.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/serialize.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/mjsunit/string-externalize.js	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Yang

Please take a look. Patch set 1 is merely r10049 that has been rolled back. ...

9 years, 1 month ago (2011-11-23 12:56:05 UTC) #1

Michael Starzinger

9 years, 1 month ago (2011-11-23 13:03:05 UTC) #2

LGTM (just looked at second patch set, rubber-stamped the first one).