Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 8677001: Roll ANGLE r887:r889 and expand and clarify the reason for its special (Closed)

Created:
9 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., bsalomon_chromium
Visibility:
Public.

Description

Roll ANGLE r887:r889 and expand and clarify the reason for its special exception in checklicenses.py. licensecheck.pl needs to understand the Bison "special exception". BUG=105232 TEST=ran checklicenses.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111388

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
Lei: since Pawel is not online right now and this is blocking dependent CLs for ...
9 years, 1 month ago (2011-11-23 04:55:14 UTC) #1
Lei Zhang
LGTM
9 years, 1 month ago (2011-11-23 04:57:57 UTC) #2
Ken Russell (switch to Gerrit)
+mal. Mark, the reason for the special exception in checklicenses.py is explained in http://crbug.com/105232 ; ...
9 years, 1 month ago (2011-11-23 05:06:54 UTC) #3
Paweł Hajdan Jr.
Is ANGLE used in the browser executable? If so, I think this should really get ...
9 years, 1 month ago (2011-11-23 10:08:10 UTC) #4
Mark Larson
LGTM This exception is OK with me. On 2011/11/23 05:06:54, kbr wrote: > +mal. Mark, ...
9 years, 1 month ago (2011-11-23 19:07:12 UTC) #5
Ken Russell (switch to Gerrit)
9 years, 1 month ago (2011-11-23 19:33:21 UTC) #6
Incorporating bsalomon's roll to r889 from
http://codereview.chromium.org/8662012 .

Powered by Google App Engine
This is Rietveld 408576698