Issue 8676046: Log server advertised protos (NPN data to NetLog).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8676046: Log server advertised protos (NPN data to NetLog). (Closed)

Created:
9 years ago by ramant (doing other things)

Modified:
9 years ago

Reviewers:
agl, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, mmenke

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Log server advertised protos (NPN data to NetLog). In net internal logs, we will log proto in the following manner: (P) t=1322696274902 [st=3128] HTTP_STREAM_REQUEST_PROTO --> next_proto_status = "Negotiated" --> proto = "spdy/2" BUG=62064 TEST=network unit tests R=willchan

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
M	net/base/net_log_event_type_list.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/http/http_stream_factory_impl_job.cc	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket.cc	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi willchan, Made the changes to log proto string and the status. Would appreciate your ...

9 years ago (2011-12-01 00:59:59 UTC) #1

willchan no longer on Chromium

agl: Are there hooks to get the server advertised NPN values? If so, it'd be ...

9 years ago (2011-12-01 05:42:24 UTC) #2

agl

9 years ago (2011-12-01 16:13:19 UTC) #3

On Thu, Dec 1, 2011 at 12:42 AM,  <willchan@chromium.org> wrote:
> agl: Are there hooks to get the server advertised NPN values? If so, it'd be
> great to log those too, and not just what we ultimately selected.

SSLClientSocketNSS::NextProtoCallback
(net/socket/ssl_client_socket_nss.cc) gets the server's NPN advert. It
can store it in the SSLClientSocketNSS if you want to log it. Seems
that you might want to expand SSLClientSocket::GetNextProto to return
it.

(The server's NPN advert will be in wire format: 8-bit length prefixed
strings. That's fine to store it (saves on space vs a vector<string>),
but you probably want to break it down when logged.)

Cheers

AGL

Expand Messages | Collapse Messages