Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 8676043: Pepper: Make the sample rate settable in the audio (output) example plugin. (Closed)

Created:
9 years ago by viettrungluu
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Make the sample rate settable in the audio (output) example plugin. Also do some other cleanup as a drive-by. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112143

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed moar constants #

Patch Set 3 : fix win #

Total comments: 1

Patch Set 4 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -26 lines) Patch
M ppapi/examples/audio/audio.cc View 1 2 3 2 chunks +52 lines, -26 lines 0 comments Download
A ppapi/examples/audio/audio.html View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
http://codereview.chromium.org/8676043/diff/1/ppapi/examples/audio/audio.cc File ppapi/examples/audio/audio.cc (right): http://codereview.chromium.org/8676043/diff/1/ppapi/examples/audio/audio.cc#newcode20 ppapi/examples/audio/audio.cc:20: const double frequency_l = 400; Maybe I should fix ...
9 years ago (2011-11-29 21:22:07 UTC) #1
viettrungluu
+piman, dmichael (since brettw is flaky) The change is "relatively trivial". Might as well get ...
9 years ago (2011-11-30 02:26:31 UTC) #2
brettw
I'm not flaky, I was taking several hours to do some actual programming. LGTM
9 years ago (2011-11-30 02:31:00 UTC) #3
viettrungluu
On 2011/11/30 02:31:00, brettw wrote: > I'm not flaky, I was taking several hours to ...
9 years ago (2011-11-30 03:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8676043/7001
9 years ago (2011-11-30 03:51:25 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 06:25:01 UTC) #6
Change committed as 112143

Powered by Google App Engine
This is Rietveld 408576698