Issue 8676032: Move RenderViewHostObserver to content/public/browser/ and put it into the content namespace.

Issue 8676032: Move RenderViewHostObserver to content/public/browser/ and put it into the content namespace. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years ago

Reviewers:
jam

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, mmenke, brettw-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move RenderViewHostObserver to content/public/browser/ and put it into the content namespace. BUG=98716 R=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111604

Patch Set 1 #

Total comments: 1

Patch Set 2 : john review #

Patch Set 3 : add render_view_host.h to DEPS file #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -176 lines)			Patch
M	chrome/browser/chromeos/login/webui_login_view.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.h	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/debugger/devtools_window.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_function.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_message_handler.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_message_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_render_view_host_observer.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_render_view_host_observer.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_view_host_observer.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_view_host_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/test_navigation_observer.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	content/browser/debugger/render_view_devtools_agent_host.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/debugger/render_view_devtools_agent_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View		7 chunks	+9 lines, -8 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_manager_browsertest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
D	content/browser/renderer_host/render_view_host_observer.h	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	content/browser/renderer_host/render_view_host_observer.cc	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	content/content_browser.gypi	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/DEPS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A +	content/public/browser/render_view_host_observer.h	View		4 chunks	+9 lines, -4 lines	0 comments	Download
A +	content/public/browser/render_view_host_observer.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm with nit, thanks for doing this http://codereview.chromium.org/8676032/diff/1/content/browser/renderer_host/render_view_host.h File content/browser/renderer_host/render_view_host.h (right): http://codereview.chromium.org/8676032/diff/1/content/browser/renderer_host/render_view_host.h#newcode57 content/browser/renderer_host/render_view_host.h:57: class RenderViewHostObserver; ...

9 years, 1 month ago (2011-11-24 21:19:59 UTC) #2

tfarina

On 2011/11/24 21:19:59, John Abd-El-Malek wrote: > lgtm with nit, thanks for doing this > ...

9 years, 1 month ago (2011-11-24 21:25:47 UTC) #3

jam

On 2011/11/24 21:25:47, tfarina wrote: > On 2011/11/24 21:19:59, John Abd-El-Malek wrote: > > lgtm ...

9 years, 1 month ago (2011-11-24 21:48:05 UTC) #4

tfarina

9 years, 1 month ago (2011-11-24 22:18:08 UTC) #5

On 2011/11/24 21:48:05, John Abd-El-Malek wrote:
> in chrome/trunk/src/content/public/browser/DEPS, just add
> 
> "+content/browser/renderer_host/render_view_host.h"

Done

Expand Messages | Collapse Messages