Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 8676028: Move shutdown code to avoid crash in WarmConnectionFieldTrial_WarmestSocket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + re-enable tests Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 5d078d33ec74b1d184cc404bf053b8db0a7e48fc..f6976dc9c4e40efaf217476da4f9bff26371b780 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -88,12 +88,8 @@ ChromeBrowserMainPartsChromeos::ChromeBrowserMainPartsChromeos(
}
ChromeBrowserMainPartsChromeos::~ChromeBrowserMainPartsChromeos() {
- chromeos::accessibility::SystemEventObserver::Shutdown();
-
chromeos::disks::DiskMountManager::Shutdown();
- chromeos::BluetoothManager::Shutdown();
-
chromeos::DBusThreadManager::Shutdown();
if (!parameters().ui_task && chromeos::CrosLibrary::Get())
@@ -222,4 +218,10 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
chromeos::DBusThreadManager::Get()->GetPowerManagerClient()
->RemoveObserver(brightness_observer_.get());
}
+
+ // Shut these down here instead of in the destructor in case we exited before
+ // running BrowserMainLoop::RunMainMessageLoopParts() and never initialized
+ // these.
+ chromeos::accessibility::SystemEventObserver::Shutdown();
+ chromeos::BluetoothManager::Shutdown();
}
« no previous file with comments | « chrome/browser/chrome_browser_main_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698