Issue 8676028: Move shutdown code to avoid crash in WarmConnectionFieldTrial_WarmestSocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8676028: Move shutdown code to avoid crash in WarmConnectionFieldTrial_WarmestSocket (Closed)

Created:
9 years, 1 month ago by stevenjb

Modified:
9 years, 1 month ago

Reviewers:
satorux1, Scott Hess - ex-Googler, Simon Que

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move shutdown code to avoid crash in WarmConnectionFieldTrial_WarmestSocket BUG=105326 TEST=Ensure unit_tests do not crash on chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111474

Patch Set 1 #

Patch Set 2 : Rebase + re-enable tests #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -37 lines)			Patch
	M	chrome/browser/chrome_browser_main_unittest.cc	View	1	3 chunks	+3 lines, -33 lines	0 comments	Download
	M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

This is causing the chromeos clang bot to fail: http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%20Clang%20%28ChromeOS%20dbg%29

9 years, 1 month ago (2011-11-24 00:15:28 UTC) #1

+sque@ FYI

Expand Messages | Collapse Messages