Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 8676021: Mark BrowserTest.DisableMenuItemsWhenIncognitoIsForced as flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
===================================================================
--- chrome/browser/ui/browser_browsertest.cc (revision 111186)
+++ chrome/browser/ui/browser_browsertest.cc (working copy)
@@ -1167,8 +1167,18 @@
forward_nav_load_observer.Wait();
}
+#if defined(OS_WIN)
+// see http://crbug.com/105306
+#define MAYBE_DisableMenuItemsWhenIncognitoIsForced \
+ FLAKY_DisableMenuItemsWhenIncognitoIsForced
+#else
+#define MAYBE_DisableMenuItemsWhenIncognitoIsForced \
+ DisableMenuItemsWhenIncognitoIsForced
+#endif
+
// Makes sure certain commands are disabled when Incognito mode is forced.
-IN_PROC_BROWSER_TEST_F(BrowserTest, DisableMenuItemsWhenIncognitoIsForced) {
+IN_PROC_BROWSER_TEST_F(BrowserTest,
+ MAYBE_DisableMenuItemsWhenIncognitoIsForced) {
CommandUpdater* command_updater = browser()->command_updater();
// At the beginning, all commands are enabled.
EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_NEW_WINDOW));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698