Detect invalid content settings pattern that were not detected yet.

chrome/common/content_settings_pattern.h

Index: chrome/common/content_settings_pattern.h
diff --git a/chrome/common/content_settings_pattern.h b/chrome/common/content_settings_pattern.h
index 187ec2439687553c8c748dcdea0bc8d643c9685d..1bc2afd6570187748ee8afb56ec514d3476998e4 100644
--- a/chrome/common/content_settings_pattern.h
+++ b/chrome/common/content_settings_pattern.h
@@ -219,8 +219,9 @@ class ContentSettingsPattern {
      virtual ContentSettingsPattern Build() OVERRIDE;
     private:
      // Canonicalizes the pattern parts so that they are ASCII only, either
-     // in original (if it was already ASCII) or punycode form.
-     static void Canonicalize(PatternParts* parts);
+     // in original (if it was already ASCII) or punycode form. Returns false if
+     // the pattern parts are not valid.

[Bernhard Bauer, 2011/11/24 15:50:32]

Canonicalize seems to use a different definition of valid than Validate below.
What's the difference?

[markusheintz_, 2011/11/24 16:37:51]

I rephrased it.

+     static bool Canonicalize(PatternParts* parts);
 
      // Returns true when the pattern |parts| represent a valid pattern.
      static bool Validate(const PatternParts& parts);