Detect invalid content settings pattern that were not detected yet.

chrome/common/content_settings_pattern.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Patterns used in content setting rules.
 
 #ifndef CHROME_COMMON_CONTENT_SETTINGS_PATTERN_H_
 #define CHROME_COMMON_CONTENT_SETTINGS_PATTERN_H_
 #pragma once
 
@@ skipping 201 matching lines @@
 
      virtual BuilderInterface* WithSchemeWildcard() OVERRIDE;
 
      virtual BuilderInterface* WithPath(const std::string& path) OVERRIDE;
 
      virtual BuilderInterface* Invalid() OVERRIDE;
 
      virtual ContentSettingsPattern Build() OVERRIDE;
     private:
      // Canonicalizes the pattern parts so that they are ASCII only, either
-     // in original (if it was already ASCII) or punycode form.
-     static void Canonicalize(PatternParts* parts);
+     // in original (if it was already ASCII) or punycode form. Returns false if
+     // the pattern parts are not valid.

[Bernhard Bauer, 2011/11/24 15:50:32]

Canonicalize seems to use a different definition of valid than Validate below.
What's the difference?

[markusheintz_, 2011/11/24 16:37:51]

I rephrased it.

+     static bool Canonicalize(PatternParts* parts);
 
      // Returns true when the pattern |parts| represent a valid pattern.
      static bool Validate(const PatternParts& parts);
 
      static bool LegacyValidate(const PatternParts& parts);
 
      bool is_valid_;
 
      bool use_legacy_validate_;
 
@@ skipping 24 matching lines @@
 };
 
 // Stream operator so ContentSettingsPattern can be used in assertion
 // statements.
 inline std::ostream& operator<<(
     std::ostream& out, const ContentSettingsPattern& pattern) {
   return out << pattern.ToString();
 }
 
 #endif  // CHROME_COMMON_CONTENT_SETTINGS_PATTERN_H_