Remove corrupted values from obsolete geolocation preference.

Remove corrupted values from obsolete geolocation preference.

BUG=103272
TEST=No DCHECK, No Crash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111518

[markusheintz_, 2011-11-23 18:26:37]

@bauerb: Could you please review my CL. Thanks.
@zea: FYI only.

[Bernhard Bauer, 2011-11-23 18:43:33]

LGTM

http://codereview.chromium.org/8676017/diff/2001/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/8676017/diff/2001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:595: // Ignor
settings with wildcard patterns as they are not supported by the
Nit: "Ignore"

http://codereview.chromium.org/8676017/diff/2001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:997: if
(dict->empty())
Removing empty dictionaries isn't necessary; the PrefService trims them
automatically when writing the preferences to disk.

[markusheintz_, 2011-11-23 18:52:28]

Thanks for reviewing the CL.

http://codereview.chromium.org/8676017/diff/2001/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/8676017/diff/2001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:595: // Ignor
settings with wildcard patterns as they are not supported by the
On 2011/11/23 18:43:33, Bernhard Bauer wrote:
> Nit: "Ignore"

Done.

http://codereview.chromium.org/8676017/diff/2001/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:997: if
(dict->empty())
On 2011/11/23 18:43:33, Bernhard Bauer wrote:
> Removing empty dictionaries isn't necessary; the PrefService trims them
> automatically when writing the preferences to disk.

True! We recently talked about this.

[commit-bot: I haz the power, 2011-11-24 09:43:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/8676017/4002

[commit-bot: I haz the power, 2011-11-24 10:50:43]

Change committed as 111518