chrome/browser/ui/panels/panel_window_controller_cocoa.mm - Issue 8676016: Mac Panels changed to hide tab contents view after tab contents are gone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 8676016: Mac Panels changed to hide tab contents view after tab contents are gone. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

index d504eee815daebb76d39f05307167ded80db7fe2..06e69df40e587410dc730d05bad69c18ca377ad3 100644

--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

@@ -249,11 +249,13 @@ enum {

- (void)tabInserted:(TabContents*)contents {

[contentsController_ changeTabContents:contents];

+ DCHECK(![[contentsController_ view] isHidden]);

}

- (void)tabDetached:(TabContents*)contents {

DCHECK(contents == [contentsController_ tabContents]);

[contentsController_ changeTabContents:NULL];

+ [[contentsController_ view] setHidden:YES];

}

- (PanelTitlebarViewCocoa*)titlebarView {

« no previous file with comments | « no previous file | no next file » | no next file with comments »