Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 8676009: fix content build on !linux && use_x11 (Closed)

Created:
9 years, 1 month ago by Robert Nagy
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

fix content build on !linux && use_x11 link to -lXcomposite and add third_party/angle/include to include_dirs because they are both needed in case X11 is used BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M content/content_common.gypi View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Nagy
I hope i've picked the right reviewers. Please review :)
9 years, 1 month ago (2011-11-23 14:03:38 UTC) #1
Mark Mentovai
LGTM. No OWNERS required, so going right into the CQ.
9 years, 1 month ago (2011-11-23 14:18:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8676009/1
9 years, 1 month ago (2011-11-23 14:18:41 UTC) #3
commit-bot: I haz the power
Try job failure for 8676009-1 (retry) (retry) on mac_rel for step "media_unittests". It's a second ...
9 years, 1 month ago (2011-11-23 16:25:09 UTC) #4
Robert Nagy
On 2011/11/23 16:25:09, I haz the power (commit-bot) wrote: > Try job failure for 8676009-1 ...
9 years, 1 month ago (2011-11-23 18:09:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8676009/1
9 years, 1 month ago (2011-11-23 18:14:21 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 19:49:32 UTC) #7
Change committed as 111393

Powered by Google App Engine
This is Rietveld 408576698