Add automated test for the edit search engine dialog.

chrome/browser/resources/edit_search_engine_dialog.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('editSearchEngineDialog', function() {
   'use strict';
 
   /**
+   * Flag inidicating if we are in the process of validating input. While
+   * validating, the validity of the inputs is indeterminate.
+   * @type {boolean}
+   * @private
+   */
+  var isValidating_ = false;
+
+  /**
+   * Flag indicating if 'setValidation' should reset the 'isValidating_' flag.
+   * We do not reset the flag during initialization.
+   * @type {boolean}
+   * @private
+   */
+  var armRevalidation_ = false;
+
+  /**
    * Disables the controls while the dialog is busy.
    */
   function disableControls() {
     $('cancel').disabled = true;
     $('save').disabled = true;
   }
 
   /**
    * Close the dialog and pass a result value to the dialog close handler.
    * @param {{description: string, details: string, url: string}=} opt_result
@@ skipping 24 matching lines @@
    */
   function setValidImage(element, valid) {
     element.className = valid ? 'valid' : 'invalid';
   }
 
   /**
    * Sends all strings to Chrome for validation.  Chrome is expected to respond
    * by calling setValidation.
    */
   function validate() {
+    isValidating_ = true;
     chrome.send('requestValidation', [$('description-text').value,
                 $('keyword-text').value, $('url-text').value]);
   }
 
   /**
    * Sets dialog state given the results of the validation of input by Chrome.
-   * @param {{description: boolean, details: boolean, url: boolean, ok:boolean}}
-   *     details A dictionary of booleans indicating the validation results of
-   *     various parts of the UI.  |description|, |details| and |url| indicate
-   *     the validity of the respective text fields, and |ok| indicates whether
+   * @param {{description: boolean,
+              keyword: boolean,
+              url: boolean,
+              ok: boolean}} details
+   *     A dictionary of booleans indicating the validation results of various
+   *     parts of the UI.  |description|, |keyword| and |url| indicate the
+   *     validity of the respective text fields, and |ok| indicates whether
    *     the OK/Save button can be pressed.
    */
   function setValidation(details) {
     setValidImage($('description-icon'), details.description);
     setValidImage($('keyword-icon'), details.keyword);
     setValidImage($('url-icon'), details.url);
     $('save').disabled = !details.ok;
+    if (armRevalidation_)
+      isValidating_ = false;
   }
 
   /**
    * Reverses the order of child nodes.
    * @param {HTMLElement} parent The parent node whose children are to be
    *     reversed.
    */
   function reverseChildren(parent) {
     var childNodes = parent.childNodes;
     for (var i = childNodes.length - 1; i >= 0; i--)
       parent.appendChild(childNodes[i]);
   };
 
   var forEach = Array.prototype.forEach.call.bind(Array.prototype.forEach);
 
   /**
    * Inserts translated strings on loading.
    */
   function initialize() {
+    // The initialization process triggers asynchronous calls.  Until these
+    // calls complete, the validity of the inputs is in an indeterminate
+    // state.
+    isValidating_ = true;
+
     i18nTemplate.process(document, templateData);
 
     document.title = chrome.dialogArguments == 'add' ? templateData.titleNew :
         templateData.titleEdit;
 
     $('cancel').onclick = function() {
       closeWithResult();
     }
 
     $('save').onclick = function() {
       closeWithResult({description: $('description-text').value,
                        keyword: $('keyword-text').value,
                        url: $('url-text').value});
     }
 
     $('description-text').oninput = validate;
     $('keyword-text').oninput = validate;
     $('url-text').oninput = validate;
 
+    // Do not mark the input as validated during the initial reset.
+    armRevalidation_ = false;
     setValidation({description: false, keyword: false, url: false});
     if (cr.isViews)
       forEach(document.querySelectorAll('.button-strip'), reverseChildren);
-    chrome.send('requestDetails')
+    // The next call to set validation will have the correct flags.
+    armRevalidation_ = true;

[flackr, 2011/11/23 15:22:37]

Is there any reason we can't set isValidating_ here and do away with
armRevalidation_?

[kevers, 2011/11/23 20:04:53]

Done.

+    chrome.send('requestDetails');
+  }
+
+  /**
+   * Indicates if we are in the process of validating input.
+   * @return {boolean} True if validation is in progress.
+   */
+  function isValidating() {
+    return isValidating_;
   }
 
   document.addEventListener('DOMContentLoaded', initialize);
 
   return {
+    isValidating: isValidating,
     setDetails: setDetails,
     setValidation: setValidation,
   };
 });