If asan==1:

If asan==1:
 -- pass the -faddress-sanitizer flag to enable ASan;
 -- pass the -fasan flag for backward compatibility;
 -- pass the -DADDRESS_SANITIZER which soon won't be defined by ASan;
 -- mark several functions missing in the 10.5 SDK as dynamic_lookup

 Whitespace fix.

TBR=thakis
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111575

[Alexander Potapenko, 2011-11-23 10:25:37]

TBR

[commit-bot: I haz the power, 2011-11-23 11:53:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/8676002/1

[commit-bot: I haz the power, 2011-11-23 13:33:48]

Try job failure for 8676002-1 (retry) on mac_rel for step "media_unittests".
It's a second try, previously, step "media_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Ryan Sleevi, 2011-11-25 07:04:57]

http://codereview.chromium.org/8676002/diff/4001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8676002/diff/4001/build/common.gypi#newcode1463
build/common.gypi:1463: 'DEAD_CODE_STRIPPING': 'NO',  # -Wl,-dead_strip
Did you mean to change this both here and on 2328?

I don't see the dead code stripping being restored for !asan

[Alexander Potapenko, 2011-11-25 07:08:49]

That's indeed what code reviews are for! In fact I didn't mean to touch
DEAD_CODE_STRIPPING at all, thanks!

Please take another look.

[Ryan Sleevi, 2011-11-25 07:10:04]

lgtm

[Ryan Sleevi, 2011-11-25 07:11:15]

http://codereview.chromium.org/8676002/diff/7001/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8676002/diff/7001/build/common.gypi#newcode1929
build/common.gypi:1929: '-DADDRESS_SANITIZER',
er, should this be in a defines, like it is for Mac?

cleanup for a separate CL perhaps, if you don't want to touch it here?

[Alexander Potapenko, 2011-11-25 07:27:55]

Let it be a separate CL.
I'm anyway going to remove the -fasan flags soon