Issue 8674002: Switch MHTMLGenerationManager to use a Callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8674002: Switch MHTMLGenerationManager to use a Callback. (Closed)

Created:
9 years, 1 month ago by Jay Civelli

Modified:
9 years, 1 month ago

Reviewers:
asanka, asargent_no_longer_on_chrome, jam

CC:
chromium-reviews, Erik does not do reviews, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Switch MHTMLGenerationManager to use a Callback. Relanding: MHTMLGenerationManager now uses a callback instead of a notification. BUG=None TEST=MHTML generation (via extension API should still work). TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111328

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -76 lines)			Patch
M	chrome/browser/extensions/extension_save_page_api.h	View	4 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_save_page_api.cc	View	2 chunks	+11 lines, -29 lines	0 comments	Download
M	content/browser/download/mhtml_generation_browsertest.cc	View	5 chunks	+22 lines, -11 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.h	View	2 chunks	+10 lines, -7 lines	0 comments	Download
M	content/browser/download/mhtml_generation_manager.cc	View	4 chunks	+7 lines, -13 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/8674002/1

9 years, 1 month ago (2011-11-23 06:43:31 UTC) #1

Change committed as 111328

Expand Messages | Collapse Messages