Issue 8673009: Remove unused BrowserBubble remnants.

Issue 8673009: Remove unused BrowserBubble remnants. (Closed)

Created:
9 years ago by msw

Modified:
9 years ago

Reviewers:
alicet1, Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused BrowserBubble remnants. The only use of BrowserBubble was deprecated in crrev.com/111886. ExtensionPopup now uses the new views bubble; this code is dead. BUG=97248, 98323 TEST=ExtensionPopup bubbles work as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112278

Patch Set 1 : Remove unused BrowserBubble remnants. #

Patch Set 2 : Remove more stale code. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -730 lines)			Patch
M	chrome/browser/automation/automation_provider_win.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/browser/ui/views/browser_bubble.h	View		1 chunk	+0 lines, -142 lines	0 comments	Download
D	chrome/browser/ui/views/browser_bubble.cc	View		1 chunk	+0 lines, -130 lines	0 comments	Download
D	chrome/browser/ui/views/browser_bubble_aura.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/browser/ui/views/browser_bubble_gtk.cc	View		1 chunk	+0 lines, -159 lines	0 comments	Download
D	chrome/browser/ui/views/browser_bubble_win.cc	View		1 chunk	+0 lines, -154 lines	0 comments	Download
D	chrome/browser/ui/views/frame/browser_bubble_host.h	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/ui/views/frame/browser_bubble_host.cc	View		1 chunk	+0 lines, -47 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_gtk.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1	3 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	6 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8673009/5015

9 years ago (2011-11-30 17:50:39 UTC) #6

commit-bot: I haz the power

Try job failure for 8673009-5015 (retry) on win_rel for step "ui_tests" (clobber build). It's a ...

9 years ago (2011-11-30 19:05:54 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8673009/5015

9 years ago (2011-11-30 19:25:28 UTC) #8

Change committed as 112278

Expand Messages | Collapse Messages