Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 8673007: Build libppapi_cpp.a under SHARED_INTERMEDIATE_DIR, so ppapi_tests can find it. (Closed)

Created:
9 years, 1 month ago by Wez
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Build libppapi_cpp.a under SHARED_INTERMEDIATE_DIR, so ppapi_tests can find it. Without this, building with ninja fails because the libppapi_cpp.a library is put in a different path under PRODUCT_DIR than it would be with make, and ppapi_tests was hard-coded to expect that path. TEST=Building with 'ninja all' doesn't give dependency errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ppapi/ppapi_cpp.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wez
At the moment it's not possible to "ninja all" - I think this should fix ...
9 years, 1 month ago (2011-11-23 01:37:40 UTC) #1
noelallen_use_chromium
LGTM
9 years, 1 month ago (2011-11-23 02:17:28 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-23 02:23:34 UTC) #3
Wez
dmichael: OWNERS LGTM, PLZ?
9 years, 1 month ago (2011-11-23 17:39:08 UTC) #4
dmichael (off chromium)
lgtm
9 years, 1 month ago (2011-11-23 19:08:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/8673007/1
9 years, 1 month ago (2011-11-23 19:08:39 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 22:00:21 UTC) #7
Change committed as 111420

Powered by Google App Engine
This is Rietveld 408576698