Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 8673006: Remove unnecessary gtest dependency from some net/ non-test targets (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi
Modified:
9 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove unnecessary gtest dependency from some net/ non-test targets BUG=none TEST=none TBR=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M net/net.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
LGTM \o/ Now to remove the dependency on http_server…
9 years, 1 month ago (2011-11-23 01:19:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8673006/1
9 years, 1 month ago (2011-11-23 03:21:42 UTC) #2
commit-bot: I haz the power
Presubmit check for 8673006-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-23 03:21:44 UTC) #3
Ryan Sleevi
raman: Mind stamping?
9 years, 1 month ago (2011-11-23 03:23:06 UTC) #4
ramant (doing other things)
lgtm
9 years, 1 month ago (2011-11-23 03:25:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8673006/1
9 years, 1 month ago (2011-11-23 03:27:08 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 04:27:47 UTC) #7
Change committed as 111314

Powered by Google App Engine
This is Rietveld 408576698