Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: bin/run_vm_tests.cc

Issue 8673002: - Refactor the isolate callback mechanism to also include creation of the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: bin/run_vm_tests.cc
===================================================================
--- bin/run_vm_tests.cc (revision 1771)
+++ bin/run_vm_tests.cc (working copy)
@@ -44,9 +44,10 @@
}
-static void* TestIsolateInitCallback(void* data) {
- ASSERT(data == NULL);
- return reinterpret_cast<void*>(0);
+static bool TestIsolateCreationCallback(Dart_IsolateError error) {
+ Dart_Isolate isolate = Dart_CreateIsolate(NULL);
+ ASSERT(isolate != NULL);
+ return true;
}
@@ -78,7 +79,7 @@
dart_argv = &argv[2];
}
bool init_success = Dart::InitOnce(dart_argc, dart_argv,
- TestIsolateInitCallback);
+ TestIsolateCreationCallback);
ASSERT(init_success);
// Apply the test filter to all registered tests.
TestCaseBase::RunAll();

Powered by Google App Engine
This is Rietveld 408576698