Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Side by Side Diff: vm/isolate_win.cc

Issue 8673002: - Refactor the isolate callback mechanism to also include creation of the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/assert.h" 5 #include "vm/assert.h"
6 #include "vm/globals.h" 6 #include "vm/globals.h"
7 #include "vm/isolate.h" 7 #include "vm/isolate.h"
8 8
9 namespace dart { 9 namespace dart {
10 10
11 DWORD isolate_key = TLS_OUT_OF_INDEXES; 11 DWORD isolate_key = TLS_OUT_OF_INDEXES;
12 12
13 13
14 void Isolate::SetCurrent(Isolate* current) { 14 void Isolate::SetCurrent(Isolate* current) {
15 ASSERT(isolate_key != TLS_OUT_OF_INDEXES); 15 ASSERT(isolate_key != TLS_OUT_OF_INDEXES);
16 BOOL result = TlsSetValue(isolate_key, current); 16 BOOL result = TlsSetValue(isolate_key, current);
17 if (!result) { 17 if (!result) {
18 FATAL("TlsSetValue failed"); 18 FATAL("TlsSetValue failed");
19 } 19 }
20 } 20 }
21 21
22 22
23 // Empty isolate init callback which is registered before VM isolate creation. 23 // Empty isolate init callback which is registered before VM isolate creation.
24 static void* VMIsolateInitCallback(void* data) { 24 static bool VMIsolateCreateCallback(void* data, Dart_ErrorBuffer error) {
25 return reinterpret_cast<void*>(1); 25 return true;
26 } 26 }
27 27
28 28
29 void Isolate::InitOnce() { 29 void Isolate::InitOnce() {
30 ASSERT(isolate_key == TLS_OUT_OF_INDEXES); 30 ASSERT(isolate_key == TLS_OUT_OF_INDEXES);
31 isolate_key = TlsAlloc(); 31 isolate_key = TlsAlloc();
32 if (isolate_key == TLS_OUT_OF_INDEXES) { 32 if (isolate_key == TLS_OUT_OF_INDEXES) {
33 FATAL("TlsAlloc failed"); 33 FATAL("TlsAlloc failed");
34 } 34 }
35 init_callback_ = VMIsolateInitCallback; 35 create_callback_ = VMIsolateCreateCallback;
36 } 36 }
37 37
38 } // namespace dart 38 } // namespace dart
OLDNEW
« vm/dart_api_impl.cc ('K') | « vm/isolate_macos.cc ('k') | vm/snapshot_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698