Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 8672007: Fix python scripts in src/media (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
imasaki1
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Fix python scripts in src/media Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. R=imasaki@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M media/tools/constrained_network_server/cns.py View 1 chunk +1 line, -2 lines 0 comments Download
M media/tools/constrained_network_server/cns_test.py View 1 chunk +1 line, -2 lines 0 comments Download
M media/tools/layout_tests/bug.py View 2 chunks +1 line, -2 lines 0 comments Download
M media/tools/layout_tests/layouttest_analyzer.py View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/layouttest_analyzer_helpers.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/layout_tests/layouttest_analyzer_helpers_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/layouttest_analyzer_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/layouttests.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/layout_tests/layouttests_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/test_expectations.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/layout_tests/test_expectations_history.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/layout_tests/test_expectations_history_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/layout_tests/trend_graph.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/layout_tests/trend_graph_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years, 1 month ago (2011-11-23 02:19:52 UTC) #1
M-A Ruel
Context: I'm going to add a presubmit check to enforce some of these rules.
9 years, 1 month ago (2011-11-23 02:20:26 UTC) #2
imasaki1
On 2011/11/23 02:20:26, Marc-Antoine Ruel wrote: > Context: I'm going to add a presubmit check ...
9 years, 1 month ago (2011-11-23 21:05:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8672007/1
9 years, 1 month ago (2011-11-23 21:23:12 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 23:33:31 UTC) #5
Change committed as 111438

Powered by Google App Engine
This is Rietveld 408576698