Cocoa: Custom drawing for GAIA avatar pictures

Cocoa: Custom drawing for GAIA avatar pictures

This CL updates the way we draw GAIA avatar pictures in the title bar and in the avatar menu bubble.

Screenshots: http://imgur.com/nxzeQ

BUG=91241
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112173

[sail, 2011-11-26 06:51:59]

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:151:
[self.buttonView setImage:image];
I moved this so that it only applies to the incognito icon. The default avatar
icons already have a shadow baked into them, adding a extra shadow looks bad.
The GAIA profile pictures don't need a shadow.

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:361: [avatarButton
setFrameSize:NSMakeSize(profiles::kAvatarIconWidth,
On my machine (10.6) tabStripHeight is 37 pixels. Since avatar icons are 38
pixels wide this lead to them being scaled and blurred.

[sail, 2011-11-28 18:47:44]

oops, forgot to publish this

[sail, 2011-11-28 18:48:02]

correct reviewers this time

[Robert Sesek, 2011-11-28 19:17:53]

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:242: bool
is_gaia_picture =
BOOL

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:362:
MIN(profiles::kAvatarIconHeight, tabStripHeight))];
std::min

[sail, 2011-11-28 19:40:31]

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:242: bool
is_gaia_picture =
On 2011/11/28 19:17:53, rsesek wrote:
> BOOL

Done.

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:362:
MIN(profiles::kAvatarIconHeight, tabStripHeight))];
On 2011/11/28 19:17:53, rsesek wrote:
> std::min

Done.

[Robert Sesek, 2011-11-28 23:03:23]

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:361: [avatarButton
setFrameSize:NSMakeSize(profiles::kAvatarIconWidth,
On 2011/11/26 06:52:00, sail wrote:
> On my machine (10.6) tabStripHeight is 37 pixels. Since avatar icons are 38
> pixels wide this lead to them being scaled and blurred.

Does this look OK now? Or should we turn on image scaling for this control?

[sail, 2011-11-28 23:11:33]

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:361: [avatarButton
setFrameSize:NSMakeSize(profiles::kAvatarIconWidth,
On 2011/11/28 23:03:23, rsesek wrote:
> On 2011/11/26 06:52:00, sail wrote:
> > On my machine (10.6) tabStripHeight is 37 pixels. Since avatar icons are 38
> > pixels wide this lead to them being scaled and blurred.
> 
> Does this look OK now? Or should we turn on image scaling for this control?

This looks really good now.
With the new control size the avatar image size matches the control exactly so
no scaling is needed.

[Robert Sesek, 2011-11-28 23:12:08]

On 2011/11/28 23:11:33, sail wrote:
>
http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
> File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):
> 
>
http://codereview.chromium.org/8671002/diff/1/chrome/browser/ui/cocoa/browser...
> chrome/browser/ui/cocoa/browser_window_controller_private.mm:361:
[avatarButton
> setFrameSize:NSMakeSize(profiles::kAvatarIconWidth,
> On 2011/11/28 23:03:23, rsesek wrote:
> > On 2011/11/26 06:52:00, sail wrote:
> > > On my machine (10.6) tabStripHeight is 37 pixels. Since avatar icons are
38
> > > pixels wide this lead to them being scaled and blurred.
> > 
> > Does this look OK now? Or should we turn on image scaling for this control?
> 
> This looks really good now.
> With the new control size the avatar image size matches the control exactly so
> no scaling is needed.

Cool. LGTM.