chrome/browser/extensions/settings/settings_observer.h - Issue 8670012: Extension Settings API: move the API functions into an object SettingsNamepace,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings/settings_observer.h

Issue 8670012: Extension Settings API: move the API functions into an object SettingsNamepace, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bug / sync Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/settings/settings_namespace.cc ('k') | chrome/browser/extensions/settings/settings_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings/settings_observer.h

diff --git a/chrome/browser/extensions/settings/settings_observer.h b/chrome/browser/extensions/settings/settings_observer.h

index ca4ebd63eda096589f543bf3091aa5f54a12657c..1d8b4c04a841f3bd5c7a92e71e3c9b8896db5bfb 100644

--- a/chrome/browser/extensions/settings/settings_observer.h

+++ b/chrome/browser/extensions/settings/settings_observer.h

@@ -7,6 +7,7 @@

#pragma once

#include "base/observer_list_threadsafe.h"

+#include "chrome/browser/extensions/settings/settings_namespace.h"

namespace extensions {

@@ -16,10 +17,10 @@ class SettingsObserver {

// Called when a list of settings have changed for an extension.

virtual void OnSettingsChanged(

const std::string& extension_id,

+ settings_namespace::Namespace settings_namespace,

const std::string& changes_json) = 0;

- protected:

- virtual ~SettingsObserver();

+ virtual ~SettingsObserver() {}

};

typedef ObserverListThreadSafe<SettingsObserver>