Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5947)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/settings/syncable_settings_storage.cc

Issue 8670012: Extension Settings API: move the API functions into an object SettingsNamepace, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/settings/settings_namespace.h ('K') | « chrome/browser/extensions/settings/settings_test_util.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/common/extensions/api/extension_api.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/settings/syncable_settings_storage.cc
diff --git a/chrome/browser/extensions/settings/syncable_settings_storage.cc b/chrome/browser/extensions/settings/syncable_settings_storage.cc
index 5cfb4ec2c82b6a01ca99f7b20e8b5f2435dd0d8d..caaaf120401539c2029bb07394cd7158e7720546 100644
--- a/chrome/browser/extensions/settings/syncable_settings_storage.cc
+++ b/chrome/browser/extensions/settings/syncable_settings_storage.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/settings/syncable_settings_storage.h"
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/extensions/settings/settings_namespace.h"
#include "chrome/browser/extensions/settings/settings_sync_util.h"
#include "chrome/browser/sync/api/sync_data.h"
#include "chrome/browser/sync/protocol/extension_setting_specifics.pb.h"
@@ -326,6 +327,7 @@ SyncError SyncableSettingsStorage::ProcessSyncChanges(
observers_->Notify(
&SettingsObserver::OnSettingsChanged,
extension_id_,
+ settings_namespace::SYNC,
SettingChange::GetEventJson(changes));
// TODO(kalman): Something sensible with multiple errors.
« chrome/browser/extensions/settings/settings_namespace.h ('K') | « chrome/browser/extensions/settings/settings_test_util.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/common/extensions/api/extension_api.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698