Extension Settings API: move the API functions into an object SettingsNamepace,

chrome/renderer/resources/extensions/schema_generated_bindings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
@@ skipping 366 matching lines @@
         return sendRequest(
             'contentSettings.getResourceIdentifiers',
             [contentType, callback],
             extendSchema(schema));
       };
     }
     ContentSetting.prototype = new CustomBindingsObject();
     customBindings['ContentSetting'] = ContentSetting;
   }
 
+  function setupStorageNamespace() {
+    function StorageNamespace(namespace, schema) {
+      // Binds an API function for a namespace to its browser-side call, e.g.
+      // experimental.settings.sync.get('foo') -> (binds to) ->
+      // experimental.settings.get('sync', 'foo').
+      //
+      // TODO(kalman): Put as a method on CustomBindingsObject and re-use (or
+      // even generate) for other APIs that need to do this.
+      function bindApiFunction(functionName) {
+        this[functionName] = function() {
+          var schema = this.parameters[functionName];
+          chromeHidden.validate(arguments, schema);
+          return sendRequest(
+              'experimental.settings.' + functionName,
+              [namespace].concat(Array.prototype.slice.call(arguments)),
+              extendSchema(schema));
+        };
+      }
+      ['get', 'set', 'remove', 'clear'].forEach(bindApiFunction.bind(this));
+    }
+    StorageNamespace.prototype = new CustomBindingsObject();
+    customBindings['StorageNamespace'] = StorageNamespace;
+  }
   function setupInputEvents() {
     chrome.experimental.input.ime.onKeyEvent.dispatch =
         function(engineID, keyData) {
       var args = Array.prototype.slice.call(arguments);
       if (this.validate_) {
         var validationErrors = this.validate_(args);
         if (validationErrors) {
           chrome.experimental.input.ime.eventHandled(requestId, false);
           return validationErrors;
         }
@@ skipping 176 matching lines @@
     }
     return "unknown";
   }
 
   chromeHidden.onLoad.addListener(function(extensionId, isExtensionProcess,
                                            isIncognitoProcess) {
     // Setup the ChromeSetting class so we can use it to construct
     // ChromeSetting objects from the API definition.
     setupChromeSetting();
 
-    // Setup the ContentSetting class so we can use it to construct
-    // ContentSetting objects from the API definition.
+    // Ditto ContentSetting.
     setupContentSetting();
 
+    // Ditto StorageNamespace.
+    setupStorageNamespace();
+
     // |apiFunctions| is a hash of name -> object that stores the
     // name & definition of the apiFunction. Custom handling of api functions
     // is implemented by adding a "handleRequest" function to the object.
     var apiFunctions = {};
 
     // Read api definitions and setup api functions in the chrome namespace.
     // TODO(rafaelw): Consider defining a json schema for an api definition
     //   and validating either here, in a unit_test or both.
     // TODO(rafaelw): Handle synchronous functions.
-    // TOOD(rafaelw): Consider providing some convenient override points
+    // TODO(rafaelw): Consider providing some convenient override points
     //   for api functions that wish to insert themselves into the call.
     var apiDefinitions = GetExtensionAPIDefinition();
     var platform = getPlatform();
 
     apiDefinitions.forEach(function(apiDef) {
       // Check platform, if apiDef has platforms key.
       if (apiDef.platforms && apiDef.platforms.indexOf(platform) == -1) {
         return;
       }
 
@@ skipping 476 matching lines @@
 
   if (!chrome.tts)
     chrome.tts = {};
 
   if (!chrome.ttsEngine)
     chrome.ttsEngine = {};
 
   if (!chrome.experimental.downloads)
     chrome.experimental.downloads = {};
 })();