Hide the max queue time / max runtime columns in about:profiler when showing the difference betwe...

chrome/browser/resources/profiler.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var g_browserBridge;
 var g_mainView;
 
 // TODO(eroman): The handling of "max" across snapshots is not correct.
 // For starters the browser needs to be aware to generate new maximums.
 // Secondly, we need to take into account the "max" of intermediary snapshots,
@@ skipping 1398 matching lines @@
         this.groupedData_[k].rows.sort(sortingFunc);
 
       // Every cached data dependency is now up to date, all that is left is
       // to actually draw the result.
       this.redrawData_();
     },
 
     getVisibleColumnKeys_: function() {
       // Figure out what columns to include, based on the selected checkboxes.
       var columns = this.getSelectionColumns_();
+      columns = columns.slice(0);
 
       // Eliminate columns which we are merging on.
       deleteValuesFromArray(columns, this.getMergeColumns_());
 
       // Eliminate columns which we are grouped on.
       if (this.sortedGroupKeys_.length > 0) {
         // The grouping will be the the same for each so just pick the first.
         var randomGroupKey = this.groupedData_[this.sortedGroupKeys_[0]].key;
 
         // The grouped properties are going to be the same for each row in our,
         // table, so avoid drawing them in our table!
         var keysToExclude = []
 
         for (var i = 0; i < randomGroupKey.length; ++i)
           keysToExclude.push(randomGroupKey[i].key);
-        columns = columns.slice(0);
         deleteValuesFromArray(columns, keysToExclude);
       }
 
+      // If we are currently showing a "diff", hide the max columns, since we
+      // are not populating it correctly. See the TODO at the top of this file.
+      if (this.getSelectedSnapshotIndexes_().length > 1)
+        deleteValuesFromArray(columns, [KEY_MAX_RUN_TIME, KEY_MAX_QUEUE_TIME]);
+
       return columns;
     },
 
     redrawData_: function() {
       // Clear the results div, sine we may be overwriting older data.
       var parent = $(RESULTS_DIV_ID);
       parent.innerHTML = '';
 
       var columns = this.getVisibleColumnKeys_();
 
@@ skipping 600 matching lines @@
           groupKey.push(entry);
         }
 
         return JSON.stringify(groupKey);
       };
     },
   };
 
   return MainView;
 })();