Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: net/http/disk_cache_based_ssl_host_info.cc

Issue 8670009: SSL Host info: Make sure that we can update certificate chains in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: I Really hate this warning! Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/disk_cache_based_ssl_host_info.cc
===================================================================
--- net/http/disk_cache_based_ssl_host_info.cc (revision 111204)
+++ net/http/disk_cache_based_ssl_host_info.cc (working copy)
@@ -44,6 +44,7 @@
&DiskCacheBasedSSLHostInfo::OnIOComplete)),
state_(GET_BACKEND),
ready_(false),
+ found_entry_(false),
hostname_(hostname),
http_cache_(http_cache),
backend_(NULL),
@@ -82,7 +83,7 @@
if (!backend_)
return;
- state_ = CREATE;
+ state_ = found_entry_ ? OPEN : CREATE;
DoLoop(OK);
}
@@ -167,9 +168,15 @@
}
int DiskCacheBasedSSLHostInfo::DoOpenComplete(int rv) {
+ if (found_entry_) {
+ state_ = CREATE_COMPLETE;
+ return rv;
+ }
wtc 2011/11/30 00:22:09 Instead of checking found_entry_ here, I suggest w
+
if (rv == OK) {
entry_ = callback_->entry();
state_ = READ;
+ found_entry_ = true;
} else {
state_ = WAIT_FOR_DATA_READY_DONE;
}

Powered by Google App Engine
This is Rietveld 408576698