SSL Host info: Make sure that we can update certificate chains in

net/http/disk_cache_based_ssl_host_info.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_
 #define NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 91 matching lines @@
   // DoSetDone is the terminal state of the write operation.
   int DoSetDone();
 
   // IsCallbackPending returns true if we have a pending callback.
   bool IsCallbackPending() const;
 
   base::WeakPtrFactory<DiskCacheBasedSSLHostInfo> weak_ptr_factory_;
   CallbackImpl* callback_;
   State state_;
   bool ready_;
+  bool found_entry_;

[wtc, 2011/11/30 00:22:09]

The way you use found_entry_ is quite tricky.  It would be
nice to document it somewhere.

Also, it seems better to change the
  CREATE
  CREATE_COMPLETE
states to
  CREATE_OR_OPEN
  CREATE_OR_OPEN_COMPLETE
states, and check found_entry_ just in DoCreateOrOpen.
This seems easier to understand that diverging the state
transitions based on found_entry_ for the Persist sequence.

   std::string new_data_;
   const std::string hostname_;
   HttpCache* const http_cache_;
   disk_cache::Backend* backend_;
   disk_cache::Entry* entry_;
   OldCompletionCallback* user_callback_;
   scoped_refptr<IOBuffer> read_buffer_;
   scoped_refptr<IOBuffer> write_buffer_;
   std::string data_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_DISK_CACHE_BASED_SSL_HOST_INFO_H_