Issue 8670004: Move GPU preliminary info collection back to UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8670004: Move GPU preliminary info collection back to UI thread. (Closed)

Created:
9 years, 1 month ago by Zhenyao Mo

Modified:
9 years, 1 month ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move GPU preliminary info collection back to UI thread. Apparently doing it on FILE thread causes a race, which causes crbug 83153. In order to move back to UI thread, we have to drop chrome channel support in GPU blacklist (it's a FILE operation); also, we have to move the collection of ATI driver version in linux to GPU process. Note that this is the minimum change required for the move. Further cleanup will follow once this is merged safely back to M16. BUG=97535 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111390

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -240 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/web_resource/gpu_blacklist_updater.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/web_resource/gpu_blacklist_updater.cc	View		2 chunks	+4 lines, -41 lines	0 comments	Download
M	chrome/test/gpu/gpu_feature_browsertest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/gpu/gpu_blacklist.h	View		6 chunks	+2 lines, -19 lines	0 comments	Download
M	content/browser/gpu/gpu_blacklist.cc	View		6 chunks	+8 lines, -66 lines	0 comments	Download
M	content/browser/gpu/gpu_blacklist_unittest.cc	View		19 chunks	+20 lines, -94 lines	0 comments	Download
M	content/gpu/gpu_info_collector_linux.cc	View		2 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

ken, can you review this? (This needs to be merged back to M16).

9 years, 1 month ago (2011-11-23 00:55:37 UTC) #1

Ken Russell (switch to Gerrit)

9 years, 1 month ago (2011-11-23 19:47:08 UTC) #2

LGTM

It's difficult to verify these behavioral changes via code review, so please
test thoroughly.

Expand Messages | Collapse Messages