net/http/http_response_headers.cc - Issue 8669014: Fix a bug where redirect chain gets lost on process swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers.cc

Issue 8669014: Fix a bug where redirect chain gets lost on process swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: latest Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_headers.cc

diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc

index f249db88e236a4ea4ddd03f0397e401a046f71ea..7b493157d454fefe2edd9fa6ac3310da39e1a2c8 100644

--- a/net/http/http_response_headers.cc

+++ b/net/http/http_response_headers.cc

@@ -353,8 +353,8 @@ void HttpResponseHeaders::RemoveHeaderWithValue(const std::string& name,

void HttpResponseHeaders::AddHeader(const std::string& header) {

CheckDoesNotHaveEmbededNulls(header);

- DCHECK_EQ('\0', raw_headers_[raw_headers_.size() - 2]);

- DCHECK_EQ('\0', raw_headers_[raw_headers_.size() - 1]);

+ //DCHECK_EQ('\0', raw_headers_[raw_headers_.size() - 2]);

+ //DCHECK_EQ('\0', raw_headers_[raw_headers_.size() - 1]);

Charlie Reis 2011/12/02 22:38:11 Needs cleanup. Why isn't this true anymore?

Matt Perry 2011/12/03 00:14:24 Oops, that was for an earlier bug that has been fi

// Don't copy the last null.

std::string new_raw_headers(raw_headers_, 0, raw_headers_.size() - 1);

new_raw_headers.append(header);